From: Simon Wilkinson <sxw@your-file-system.com>
Date: Tue, 12 Feb 2013 12:19:42 +0000 (+0000)
Subject: auth: Remove unecessary assignment
X-Git-Tag: upstream/1.8.0_pre1^2~1530
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=a14cf594067481b3594f469797d44cb9cb7a0c38;p=packages%2Fo%2Fopenafs.git

auth: Remove unecessary assignment

When we're counting the number of keys available, we don't need to
actually extract each key entry - remove the unused assignment.

Caught by clang-analyzer.

Change-Id: I98a30afccaf9a455ea0a7e77e7ca0d648abe4e70
Reviewed-on: http://gerrit.openafs.org/9145
Reviewed-by: Marc Dionne <marc.c.dionne@gmail.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
---

diff --git a/src/auth/keys.c b/src/auth/keys.c
index 938c73114..13bb64761 100644
--- a/src/auth/keys.c
+++ b/src/auth/keys.c
@@ -846,10 +846,8 @@ afsconf_GetAllKeys(struct afsconf_dir *dir, struct afsconf_typedKeyList **keys)
 	typeEntry = opr_queue_Entry(typeCursor, struct keyTypeList, link);
 	for (opr_queue_Scan(&typeEntry->kvnoList, kvnoCursor)) {
 	    kvnoEntry = opr_queue_Entry(kvnoCursor, struct kvnoList, link);
-	    for (opr_queue_Scan(&kvnoEntry->subTypeList, subCursor)) {
-		subEntry = opr_queue_Entry(subCursor, struct subTypeList, link);
+	    for (opr_queue_Scan(&kvnoEntry->subTypeList, subCursor))
 		count++;
-	    }
 	}
     }