From: Nickolai Zeldovich <kolya@mit.edu>
Date: Thu, 15 Mar 2001 17:50:34 +0000 (+0000)
Subject: pts-args-checking-when-calling-com-err-20010314
X-Git-Tag: BP-openafs-devel-autoconf~30
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=a1fac47017ee0448ed7d87d2005f6fd54ae32de7;p=packages%2Fo%2Fopenafs.git

pts-args-checking-when-calling-com-err-20010314

"This prevents pts from crashing like this:

  pepsi-one~> pts createg a:b -id -1234
  /bin/athena/pts: Permission denied ; unable to create group a:b with id -1234
owned by 'Segmentation fault
"
---

diff --git a/src/ptserver/pts.c b/src/ptserver/pts.c
index 23b988408..bb19f1e79 100644
--- a/src/ptserver/pts.c
+++ b/src/ptserver/pts.c
@@ -125,8 +125,11 @@ CreateGroup (as)
 	if (code) {
 	    if (owner || id) 
 		com_err (whoami, code,
-			 "; unable to create group %s with id %d owned by '%s' %s",
-			 namei->data, id, owner, (force?"(ignored)":""));
+			 "; unable to create group %s with id %d%s%s%s%s",
+			 namei->data, id, owner ? " owned by '" : "",
+			 owner ? owner : "",
+			 owner ? "'" : "",
+			 (force ? " (ignored)" : ""));
 	    else com_err (whoami, code,
 			 "; unable to create group %s %s", namei->data, (force?"(ignored)":""));
 	    if (!force)