From: Simon Wilkinson <sxw@your-file-system.com>
Date: Tue, 19 Feb 2013 15:23:25 +0000 (+0000)
Subject: kauth: Don't store the old signal routine
X-Git-Tag: upstream/1.8.0_pre1^2~1503
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=a2aad6f4519cba38f3f0aaa03d108de4b0119be5;p=packages%2Fo%2Fopenafs.git

kauth: Don't store the old signal routine

If we're not going to make use of the return from signal() don't
bother assigning it to a variable

Change-Id: I03cae7ab91d49e90f150a9dc4358c173920adc28
Reviewed-on: http://gerrit.openafs.org/9173
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
---

diff --git a/src/kauth/user.c b/src/kauth/user.c
index 49ef3bcc7..a463083b4 100644
--- a/src/kauth/user.c
+++ b/src/kauth/user.c
@@ -135,9 +135,6 @@ ka_UserAuthenticateGeneral(afs_int32 flags, char *name, char *instance,
     int remainingTime = 0;
     struct ktc_encryptionKey key;
     afs_int32 code, dosetpag = 0;
-#if !defined(AFS_NT40_ENV) && !defined(AFS_LINUX20_ENV) && !defined(AFS_USR_LINUX20_ENV) && !defined(AFS_XBSD_ENV) || defined(AFS_FBSD_ENV)
-    void (*old)(int);
-#endif
 
     if (reasonP)
 	*reasonP = "";
@@ -171,7 +168,7 @@ ka_UserAuthenticateGeneral(afs_int32 flags, char *name, char *instance,
 
 #if !defined(AFS_NT40_ENV) && !defined(AFS_LINUX20_ENV) && !defined(AFS_USR_LINUX20_ENV) && (!defined(AFS_XBSD_ENV) || defined(AFS_FBSD_ENV))
     /* handle smoothly the case where no AFS system calls exists (yet) */
-    old = signal(SIGSYS, SIG_IGN);
+    (void)signal(SIGSYS, SIG_IGN);
 #endif
 #ifdef	AFS_DECOSF_ENV
     (void)signal(SIGTRAP, SIG_IGN);