From: Jeffrey Hutzelman <jhutz@cmu.edu>
Date: Thu, 9 Nov 2006 02:16:23 +0000 (+0000)
Subject: DEVEL15-bozo-avoid-garbage-in-allprocs-20061108
X-Git-Tag: openafs-devel-1_5_11~18
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=a4815656317a408e99ec8653aa0850cc5b124c9a;p=packages%2Fo%2Fopenafs.git

DEVEL15-bozo-avoid-garbage-in-allprocs-20061108


if we error, don't put garbage in allProcs


(cherry picked from commit ea4e9f1841dccebf37e9287334442a1ac2f928b3)
---

diff --git a/src/bozo/bnode.c b/src/bozo/bnode.c
index fd9603ae4..42a14daaa 100644
--- a/src/bozo/bnode.c
+++ b/src/bozo/bnode.c
@@ -912,8 +912,6 @@ bnode_NewProc(struct bnode *abnode, char *aexecString, char *coreName,
     tp = (struct bnode_proc *)malloc(sizeof(struct bnode_proc));
     memset(tp, 0, sizeof(struct bnode_proc));
     tp->next = allProcs;
-    allProcs = tp;
-    *aproc = tp;
     tp->bnode = abnode;
     tp->comLine = aexecString;
     tp->coreName = coreName;	/* may be null */
@@ -937,6 +935,8 @@ bnode_NewProc(struct bnode *abnode, char *aexecString, char *coreName,
     }
 
     bnode_FreeTokens(tlist);
+    allProcs = tp;
+    *aproc = tp;
     tp->pid = cpid;
     tp->flags = BPROC_STARTED;
     tp->flags &= ~BPROC_EXITED;