From: Jeffrey Altman <jaltman@secure-endpoints.com>
Date: Tue, 27 Jun 2006 22:48:23 +0000 (+0000)
Subject: windows-uninitialized-vars-20060627
X-Git-Tag: BP-openafs-windows-kdfs-ifs~1234
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=a8e481ddd92744944d2b06fd5c8ed28383297f6a;p=packages%2Fo%2Fopenafs.git

windows-uninitialized-vars-20060627


uninitialized pointers when dereferenced do bad things
---

diff --git a/src/WINNT/afsd/cm_callback.c b/src/WINNT/afsd/cm_callback.c
index 0d7f4f4da..ab4cf3578 100644
--- a/src/WINNT/afsd/cm_callback.c
+++ b/src/WINNT/afsd/cm_callback.c
@@ -1618,7 +1618,7 @@ long cm_GetCallback(cm_scache_t *scp, struct cm_user *userp,
                     struct cm_req *reqp, long flags)
 {
     long code;
-    cm_conn_t *connp;
+    cm_conn_t *connp = NULL;
     AFSFetchStatus afsStatus;
     AFSVolSync volSync;
     AFSCallBack callback;
@@ -1627,7 +1627,7 @@ long cm_GetCallback(cm_scache_t *scp, struct cm_user *userp,
     int mustCall;
     long sflags;
     cm_fid_t sfid;
-    struct rx_connection * callp;
+    struct rx_connection * callp = NULL;
 
     osi_Log4(afsd_logp, "GetCallback scp 0x%p cell %d vol %d flags %lX", 
              scp, scp->fid.cell, scp->fid.volume, flags);