From: Chas Williams (CONTRACTOR) <chas@cmf.nrl.navy.mil>
Date: Wed, 20 Nov 2013 18:57:13 +0000 (-0500)
Subject: cmd: Correctly initialize cmd_OptionAsString arguments
X-Git-Tag: upstream/1.8.0_pre1^2~887
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=a95b1f2f15d3f8efff74ad7df5085b8f30885dbc;p=packages%2Fo%2Fopenafs.git

cmd: Correctly initialize cmd_OptionAsString arguments

These are coming from the stack and as such they might not be NULL.

Change-Id: Ia5c6efd08574b4de05a11dceae47021b0160395b
Reviewed-on: http://gerrit.openafs.org/10475
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
---

diff --git a/src/volser/volmain.c b/src/volser/volmain.c
index 6c6ad5359..f8bbd2f73 100644
--- a/src/volser/volmain.c
+++ b/src/volser/volmain.c
@@ -242,10 +242,10 @@ static int
 ParseArgs(int argc, char **argv) {
     int code;
     int optval;
-    char *optstring;
+    char *optstring = NULL;
     struct cmd_syndesc *opts;
-    char *sleepSpec;
-    char *sync_behavior;
+    char *sleepSpec = NULL;
+    char *sync_behavior = NULL;
 
     opts = cmd_CreateSyntax(NULL, NULL, NULL, NULL);
     cmd_AddParmAtOffset(opts, OPT_log, "-log", CMD_FLAG, CMD_OPTIONAL,