From: Simon Wilkinson <sxw@your-file-system.com>
Date: Tue, 11 Oct 2011 00:01:26 +0000 (-0500)
Subject: dir: Remove double release in FindBlobs
X-Git-Tag: upstream/1.8.0_pre1^2~3163
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=ab866c821a705d7911e0ff8ac987249efdc63435;p=packages%2Fo%2Fopenafs.git

dir: Remove double release in FindBlobs

When DRead() fails, we DRelease the entrybuf, then break. However,
this break takes us to the end of the function, where we promptly
DRelease again, causing a double free

Change-Id: I5a0293990e01376525d8adae25477c64e2cc93ad
Reviewed-on: http://gerrit.openafs.org/5655
Reviewed-by: Derrick Brashear <shadow@dementix.org>
Tested-by: Derrick Brashear <shadow@dementix.org>
---

diff --git a/src/dir/dir.c b/src/dir/dir.c
index 9e31cee4a..521145b19 100644
--- a/src/dir/dir.c
+++ b/src/dir/dir.c
@@ -235,7 +235,6 @@ FindBlobs(dir_file_t dir, int nblobs)
 
 	    /* read the page in. */
 	    if (DRead(dir, i, &pagebuf) != 0) {
-		DRelease(&headerbuf, 1);
 		break;
 	    }
 	    pp = (struct PageHeader *)pagebuf.data;