From: Rob Browning <rlb@defaultvalue.org>
Date: Sat, 14 Mar 2015 15:39:19 +0000 (-0500)
Subject: Makefile: fix -j race to create ./bup
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=acaabbfb0a14c3c981e6b9005e0503c46a4e6eca;p=packages%2Fb%2Fbup.git

Makefile: fix -j race to create ./bup

Previously the bup target might fail if it was run in parallel
(i.e. during make -j).  Since bup depends on _version.py, which is
phony, that wasn't unlikely.

Fix the race by ignoring errors while creating the symlink, and then
testing for existence afterward.

Signed-off-by: Rob Browning <rlb@defaultvalue.org>
Tested-by: Rob Browning <rlb@defaultvalue.org>
---

diff --git a/Makefile b/Makefile
index a024dbe..181d42c 100644
--- a/Makefile
+++ b/Makefile
@@ -18,7 +18,8 @@ all: bup Documentation/all
 	t/configure-sampledata --setup
 
 bup: lib/bup/_version.py lib/bup/_helpers$(SOEXT) cmds main.py
-	ln -sf main.py bup
+	-ln -s main.py bup
+	test -L bup
 
 Documentation/all: bup