From: Derrick Brashear <shadow@dementia.org>
Date: Thu, 23 Dec 2010 18:20:42 +0000 (-0500)
Subject: DAFS: listvol + unsalvagable volumes = intolerable delay
X-Git-Tag: upstream/1.8.0_pre1^2~4338
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=affc978be7ba3c36c9b7a6a94fb5e907beebed99;p=packages%2Fo%2Fopenafs.git

DAFS: listvol + unsalvagable volumes = intolerable delay

a non- inService volume (or more) plus vos listvol equals pain.
return Salvaging instead of waiting for it in the listvol case.

Change-Id: I02bdbb6448bcf56e97db9324aa723cc753a37632
Reviewed-on: http://gerrit.openafs.org/3588
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
---

diff --git a/src/volser/volprocs.c b/src/volser/volprocs.c
index 8fdd5860f..70d002a72 100644
--- a/src/volser/volprocs.c
+++ b/src/volser/volprocs.c
@@ -2229,7 +2229,10 @@ GetVolInfo(afs_uint32 partId,
     }
 
     /* Get volume from volserver */
-    tv = VAttachVolumeByName_retry(&error, pname, volname, V_PEEK);
+    if (mode == VOL_INFO_LIST_MULTIPLE)
+	tv = VAttachVolumeByName(&error, pname, volname, V_PEEK);
+    else
+	tv = VAttachVolumeByName_retry(&error, pname, volname, V_PEEK);
     if (error) {
 	Log("1 Volser: GetVolInfo: Could not attach volume %u (%s:%s) error=%d\n",
 	    volumeId, pname, volname, error);