From: Derrick Brashear <shadow@dementia.org>
Date: Tue, 27 Aug 2002 21:46:16 +0000 (+0000)
Subject: namei-close-directory-behind-us-always-20020827
X-Git-Tag: openafs-devel-1_3_50~627
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=b5677719dc204a2b8d039594b8c70bfee3914896;p=packages%2Fo%2Fopenafs.git

namei-close-directory-behind-us-always-20020827


more or less verbatim as suggested by kolya@mit.edu

avoid leaking directory fds if we get an error
---

diff --git a/src/vol/namei_ops.c b/src/vol/namei_ops.c
index e1cb1f63d..df6371e6e 100644
--- a/src/vol/namei_ops.c
+++ b/src/vol/namei_ops.c
@@ -317,8 +317,8 @@ delTree(char *root, char *tree, int *errp)
 	 */
 	*cp = 0; 
       }
-      if (!errno)
-	closedir(ds);
+      /* if (!errno) -- closedir not implicit if we got an error */
+      closedir(ds);
     } 
     
     /* finally axe the current dir */