From: Simon Wilkinson <sxw@your-file-system.com>
Date: Tue, 19 Feb 2013 16:13:34 +0000 (+0000)
Subject: ubik: Don't record result of select()
X-Git-Tag: upstream/1.8.0_pre1^2~1467
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=b92fbc217c80af7554bbf6dc34de720da8f01c5c;p=packages%2Fo%2Fopenafs.git

ubik: Don't record result of select()

We never do anything with the return value from select(), so don't
bother storing it into code.

Caught by clang-analyzer

Change-Id: I6e0352b74f0e90b62ad32a3ef1a9d0173bf307ee
Reviewed-on: http://gerrit.openafs.org/9181
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
---

diff --git a/src/ubik/beacon.c b/src/ubik/beacon.c
index 91a2b2999..a3a48d6c8 100644
--- a/src/ubik/beacon.c
+++ b/src/ubik/beacon.c
@@ -421,12 +421,11 @@ ubeacon_Interact(void *dummy)
 	    tt.tv_sec = temp;
 	    tt.tv_usec = 0;
 #ifdef AFS_PTHREAD_ENV
-	    code = select(0, 0, 0, 0, &tt);
+	    select(0, 0, 0, 0, &tt);
 #else
-	    code = IOMGR_Select(0, 0, 0, 0, &tt);
+	    IOMGR_Select(0, 0, 0, 0, &tt);
 #endif
-	} else
-	    code = 0;
+	}
 
 	lastWakeupTime = FT_ApproxTime();	/* started a new collection phase */