From: Andrew Deason Date: Fri, 1 Jul 2011 21:58:06 +0000 (-0500) Subject: vol: Don't always FDH_REALLYCLOSE on linktable ops X-Git-Tag: upstream/1.6.0.pre7^2~21 X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=baaf9beb35fc5edaaf524a172a755e70d50ef140;p=packages%2Fo%2Fopenafs.git vol: Don't always FDH_REALLYCLOSE on linktable ops If we dec a linktable entry or get a free tag from the link table, there is no reason to FDH_REALLYCLOSE the linktable fd handle. FDH_REALLYCLOSE is the same as FDH_CLOSE, except that it tells the ihandle package that the file handle will not be used again soon. If we dec a linktable entry or get a free tag, there is no reason to think that, so just FDH_CLOSE the handle instead. Reviewed-on: http://gerrit.openafs.org/4903 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 78e39417af6d2b87f0cbda0b5d3bb3e4859dc0ba) Change-Id: I28f5abee59265403362f3f1472a9fa21a52597c0 Reviewed-on: http://gerrit.openafs.org/4949 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear --- diff --git a/src/vol/namei_ops.c b/src/vol/namei_ops.c index 659577612..59267d0ab 100644 --- a/src/vol/namei_ops.c +++ b/src/vol/namei_ops.c @@ -1052,7 +1052,7 @@ namei_dec(IHandle_t * ih, Inode ino, int p1) } if (count > 0) { - FDH_REALLYCLOSE(fdP); + FDH_CLOSE(fdP); IH_RELEASE(tmp); return 0; } @@ -1527,7 +1527,7 @@ GetFreeTag(IHandle_t * ih, int vno) } FDH_SYNC(fdP); FDH_UNLOCKFILE(fdP, offset); - FDH_REALLYCLOSE(fdP); + FDH_CLOSE(fdP); return col; badGetFreeTag: