From: Simon Wilkinson <sxw@your-file-system.com>
Date: Fri, 30 Mar 2012 18:30:18 +0000 (+0100)
Subject: vol: Remove unneeded braces
X-Git-Tag: upstream/1.6.8^2~79
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=bdb61cc567939386c3685f15ef2ac47bcff8f9ae;p=packages%2Fo%2Fopenafs.git

vol: Remove unneeded braces

Doing if ((a==b)) is unecessary. It's also potentially dangerous, as
that's the syntax required to do assignment within an if statement.
clang now issues warnings (errors in -Werror mode) when it encounters
these.

Remove pointless braces from vol to make clang happy.

Reviewed-on: http://gerrit.openafs.org/7082
Reviewed-by: Derrick Brashear <shadow@dementix.org>
Tested-by: Derrick Brashear <shadow@dementix.org>
(cherry picked from commit 58be19d792e6b8e93fbd49bc4ef04bbb8f4560ef)

Change-Id: Ie2fd97927eace8a9317598c1b44d2c2610cdc31a
Reviewed-on: http://gerrit.openafs.org/10739
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
---

diff --git a/src/vol/volume.c b/src/vol/volume.c
index b76344a1d..f88c6fbbd 100644
--- a/src/vol/volume.c
+++ b/src/vol/volume.c
@@ -8342,7 +8342,7 @@ VLookupVolume_r(Error * ec, VolId volumeId, Volume * hint)
     /* search the chain for this volume id */
     for(queue_Scan(head, vp, np, Volume)) {
 	looks++;
-	if ((vp->hashid == volumeId)) {
+	if (vp->hashid == volumeId) {
 	    break;
 	}
     }