From: Jeffrey Altman <jaltman@secure-endpoints.com>
Date: Tue, 24 Feb 2004 20:23:42 +0000 (+0000)
Subject: remove-nbt-reg-entry-on-XP-20040224
X-Git-Tag: openafs-devel-1_3_60~95
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=be6c29629b697077cdbeb979e9a8e8b149726267;p=packages%2Fo%2Fopenafs.git

remove-nbt-reg-entry-on-XP-20040224


In discussions with Andrei Keis at Morgan Stanley it has become clear
that the NBT registry parameter which disables the use of port 445
should only be used on Windows 2000.
---

diff --git a/src/WINNT/install/NSIS/OpenAFS.nsi b/src/WINNT/install/NSIS/OpenAFS.nsi
index c429f4199..e2b3f7d15 100644
--- a/src/WINNT/install/NSIS/OpenAFS.nsi
+++ b/src/WINNT/install/NSIS/OpenAFS.nsi
@@ -593,8 +593,12 @@ Section "AFS Client" secClient
    DeleteRegValue HKLM "${AFS_REGKEY_ROOT}\AFS Client\CurrentVersion" "Debug"
    DeleteRegValue HKLM "${AFS_REGKEY_ROOT}\AFS Client\${AFS_VERSION}" "Debug"
 !endif
-   ; Set network settings
-  WriteRegDWORD HKLM "SYSTEM\CurrentControlSet\Services\NetBT\Parameters" "SmbDeviceEnabled" 0
+
+   ; On Windows 2000 work around KB301673.  This is fixed in Windows XP and 2003
+   Call GetWindowsVersion
+   Pop $R1
+   StrCmp $R1 "2000" +1 +2
+   WriteRegDWORD HKLM "SYSTEM\CurrentControlSet\Services\NetBT\Parameters" "SmbDeviceEnabled" 0
   
   ;Write start menu entries
   CreateDirectory "$SMPROGRAMS\OpenAFS\Client"