From: Garrett Wollman <wollman@csail.mit.edu>
Date: Tue, 9 Aug 2011 03:26:38 +0000 (-0400)
Subject: bos: don't dereference a null pointer when printing an error message
X-Git-Tag: upstream/1.8.0_pre1^2~3428
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=bf4b2fd3e26dcf2a0db704815e05d77a558d38c6;p=packages%2Fo%2Fopenafs.git

bos: don't dereference a null pointer when printing an error message

The parameter we are interested in is at MRAFS_OFFSET + 17, not
MRAFS_OFFSET + 13.

Change-Id: Ib856ff40c5949cde95a2b277cd44253b87c3c2a4
Found-by: clang static analyzer
Reviewed-on: http://gerrit.openafs.org/5178
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
---

diff --git a/src/bozo/bos.c b/src/bozo/bos.c
index 5d74868bc..e108f225e 100644
--- a/src/bozo/bos.c
+++ b/src/bozo/bos.c
@@ -1566,7 +1566,7 @@ SalvageCmd(struct cmd_syndesc *as, void *arock)
 			       &mrafsParm.OptResidencies);
 	    if (code) {
 		printf("bos: '%s' is not a valid residency mask.\n",
-		       as->parms[MRAFS_OFFSET + 13].items->data);
+		       as->parms[MRAFS_OFFSET + 17].items->data);
 		return code;
 	    }
 	}