From: Simon Wilkinson <sxw@your-file-system.com>
Date: Thu, 28 Feb 2013 22:07:12 +0000 (+0000)
Subject: libadmin: Don't free garbage
X-Git-Tag: upstream/1.8.0_pre1^2~1377
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=bf78bf2c115659b78c34d3bc9d1934bcff21c8cc;p=packages%2Fo%2Fopenafs.git

libadmin: Don't free garbage

Make sure that we initialise the nbulkentries structure to 0 before
we start work, so that if the failure handler is called, it doesn't
try to free garbage.

Caught by coverity (#985980)

Change-Id: If55faadd44f7bbc80abbdcd7842603d586db7581
Reviewed-on: http://gerrit.openafs.org/9317
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
---

diff --git a/src/libadmin/vos/afs_vosAdmin.c b/src/libadmin/vos/afs_vosAdmin.c
index 1fb8c00a5..12b116445 100644
--- a/src/libadmin/vos/afs_vosAdmin.c
+++ b/src/libadmin/vos/afs_vosAdmin.c
@@ -325,7 +325,8 @@ vos_BackupVolumeCreateMultiple(const void *cellHandle,
     int equal = 0;
     char backbuf[1024];
 
-    memset((void *)&attr, 0, sizeof(attr));
+    memset(&attr, 0, sizeof(attr));
+    memset(&arrayEntries, 0, sizeof(arrayEntries));
 
     /*
      * Validate arguments