From: Ben Kaduk <kaduk@mit.edu>
Date: Sun, 4 Jul 2010 02:58:39 +0000 (-0400)
Subject: Do not recurse on the glock in rxk_NewSocketHost
X-Git-Tag: openafs-devel-1_5_75~5
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=bf8746dc43567a0a8f1d4075402eb9d2f741ec04;p=packages%2Fo%2Fopenafs.git

Do not recurse on the glock in rxk_NewSocketHost

If sobind() failed, we would lock the glock before going to bad,
which proceeded to lock the glock, panic()ing on the recursion attempt.
Remove the unneeded first call.

Change-Id: Ifa793735ebe64bde98156caa610c06612bdb92bd
Reviewed-on: http://gerrit.openafs.org/2330
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
---

diff --git a/src/rx/rx_kcommon.c b/src/rx/rx_kcommon.c
index d88ee40cf..17da066de 100644
--- a/src/rx/rx_kcommon.c
+++ b/src/rx/rx_kcommon.c
@@ -951,7 +951,6 @@ rxk_NewSocketHost(afs_uint32 ahost, short aport)
     if (code) {
 	dpf(("sobind fails (%d)\n", (int)code));
 	soclose(newSocket);
-	AFS_GLOCK();
 	goto bad;
     }
 #else /* defined(AFS_DARWIN_ENV) || defined(AFS_FBSD_ENV) */