From: Jeffrey Altman Date: Thu, 19 Nov 2009 23:11:06 +0000 (-0500) Subject: viced: set volume sync data in bulk status rpcs X-Git-Tag: openafs-stable-1_4_12pre1~86 X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=c286361d75323b32590fb8fc54d93b4f8c6ce07e;p=packages%2Fo%2Fopenafs.git viced: set volume sync data in bulk status rpcs The bulkstatus and inlinebulkstatus rpcs have a bug that prevents the volume sync data from being set. Currently the data is being set within the for loop only when i == nfiles. The conditional of the loop is i < nfiles so the SetVolumeSync call is never performed. This patch changes the test for performing SetVolumeSync to i == 0. LICENSE MIT Change-Id: I17e3980184ec68e38c5186e1c9637ac6e38451fe Reviewed-on: http://gerrit.openafs.org/856 Reviewed-by: Dan Hyde Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear (cherry picked from commit 13843d852749ba081804f3af368620db7b4b7d7a) Reviewed-on: http://gerrit.openafs.org/914 --- diff --git a/src/viced/afsfileprocs.c b/src/viced/afsfileprocs.c index 5becb0195..92338b424 100644 --- a/src/viced/afsfileprocs.c +++ b/src/viced/afsfileprocs.c @@ -2696,7 +2696,7 @@ SRXAFS_BulkStatus(struct rx_call * acall, struct AFSCBFids * Fids, &rights, &anyrights))) goto Bad_BulkStatus; /* set volume synchronization information, but only once per call */ - if (i == nfiles) + if (i == 0) SetVolumeSync(Sync, volptr); /* Are we allowed to fetch Fid's status? */ @@ -2857,7 +2857,7 @@ SRXAFS_InlineBulkStatus(struct rx_call * acall, struct AFSCBFids * Fids, } /* set volume synchronization information, but only once per call */ - if (i == nfiles) + if (i == 0) SetVolumeSync(Sync, volptr); /* Are we allowed to fetch Fid's status? */