From: Rod Widdowson <rdw@steadingsoftware.com>
Date: Fri, 23 Sep 2011 15:37:43 +0000 (+0100)
Subject: Fix buffer leak in dir/buffers.c
X-Git-Tag: upstream/1.8.0_pre1^2~3233
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=c2f7627a89e50713dc963ece2ef086cd991c15aa;p=packages%2Fo%2Fopenafs.git

Fix buffer leak in dir/buffers.c

Checkin 0284e65f97861e888d95576f22a93cd681813c39 accidently
threw in a trailing semicolon after an if statement.
Since the next line was a break this had several unfortunate
side effects, the most obvious being that we leaked a buffer
in certain cases.

Change-Id: I4f1043426cac22c70b64731c98ac858d82e2f11e
Reviewed-on: http://gerrit.openafs.org/5498
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
---

diff --git a/src/dir/dir.c b/src/dir/dir.c
index 570c2dbe6..9e31cee4a 100644
--- a/src/dir/dir.c
+++ b/src/dir/dir.c
@@ -473,7 +473,7 @@ afs_dir_IsEmpty(dir_file_t dir)
 	while (num != 0 && elements < BIGMAXPAGES * EPP) {
 	    elements++;
 	    /* Walk down the hash table list. */
-	    if (afs_dir_GetVerifiedBlob(dir, num, &entrybuf) != 0);
+	    if (afs_dir_GetVerifiedBlob(dir, num, &entrybuf) != 0)
 	        break;
 	    ep = (struct DirEntry *)entrybuf.data;
 	    if (strcmp(ep->name, "..") && strcmp(ep->name, ".")) {