From: Jeffrey Altman <jaltman@secure-endpoints.com>
Date: Wed, 21 Nov 2007 19:34:36 +0000 (+0000)
Subject: DEVEL15-giveupallcallbacks-locking-20071121
X-Git-Tag: openafs-devel-1_5_28~49
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=c7c23cc69909cbd0c313616d3bf1a39b251147f5;p=packages%2Fo%2Fopenafs.git

DEVEL15-giveupallcallbacks-locking-20071121

FIXES 74708


Hold H_LOCK across calls into GiveUpAllCallbacks_r


(cherry picked from commit b0b3565b69b0b8fda46b25e7bd73c5116b32d83e)
---

diff --git a/src/viced/afsfileprocs.c b/src/viced/afsfileprocs.c
index fa26512ac..e8bed09f2 100644
--- a/src/viced/afsfileprocs.c
+++ b/src/viced/afsfileprocs.c
@@ -5981,7 +5981,9 @@ common_GiveUpCallBacks(struct rx_call *acall, struct AFSCBFids *FidArray,
 		 (tcon->peer ? tcon->peer->host : 0)));
 	errorCode = GetClient(tcon, &client);
 	if (!errorCode) {
+	    H_LOCK;
 	    DeleteAllCallBacks_r(client->host, 1);
+	    H_UNLOCK;
 	    PutClient(&client);
 	}
     } else {