From: Mark Vitale <mvitale@sinenomine.net>
Date: Tue, 26 Jun 2018 09:26:21 +0000 (-0400)
Subject: OPENAFS-SA-2018-002 kaserver: prevent KAM_ListEntry information leak
X-Git-Tag: upstream/1.8.2^2~15
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=c912830e9c82d91bccf85018ef1e6a75edc410c4;p=packages%2Fo%2Fopenafs.git

OPENAFS-SA-2018-002 kaserver: prevent KAM_ListEntry information leak

KAM_ListEntry (kas list) does not initialize its output correctly.  It
leaks kaserver memory contents over the wire:

struct kaindex
- up to 64 bytes for member name
- up to 64 bytes for member instance

Initialize the buffer.

[kaduk@mit.edu: move initialization to top of server routine]

(cherry picked from commit b604ee7add7be416bf20973422a041e913d20761)

Change-Id: Ic40bb2d5af409399c11a378340ba92174e26112f
---

diff --git a/src/kauth/kaprocs.c b/src/kauth/kaprocs.c
index 315096a46..1c6c68f97 100644
--- a/src/kauth/kaprocs.c
+++ b/src/kauth/kaprocs.c
@@ -1700,6 +1700,7 @@ kamListEntry(struct rx_call *call,
     afs_int32 caller;
     struct kaentry tentry;
 
+    memset(name, 0, sizeof(*name));
     COUNT_REQ(ListEntry);
     if ((code = InitAuthServ(&tt, LOCKREAD, this_op)))
 	return code;