From: Nickolai Zeldovich <kolya@mit.edu>
Date: Tue, 29 Jan 2002 19:52:14 +0000 (+0000)
Subject: STABLE12-rx-cleanup-deadlock-and-refcnt-leak-20020121
X-Git-Tag: openafs-stable-1_2_3~2
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=cd944733be5105e4aecaee8d6056a146c1c84ca4;p=packages%2Fo%2Fopenafs.git

STABLE12-rx-cleanup-deadlock-and-refcnt-leak-20020121


The first part of the patch fixes a likely deadlock in the
case when we're destroying a client connection with active
calls.

The second part fixes a minor connection refcount leak in
my recent modification to protect against half-reachable
clients.
---

diff --git a/src/rx/rx.c b/src/rx/rx.c
index 21d456ba3..f4c255da7 100644
--- a/src/rx/rx.c
+++ b/src/rx/rx.c
@@ -899,7 +899,7 @@ static void rxi_DestroyConnectionNoLock(conn)
 				   RX_CALL_REFCOUNT_DELAY);
 		    if (call->state == RX_STATE_PRECALL ||
 			call->state == RX_STATE_ACTIVE) {
-			rxi_SendDelayedAck(call->delayedAckEvent, call, 0);
+			rxi_SendAck(call, 0, 0, 0, 0, RX_ACK_DELAY, 0);
 		    } else {
 			rxi_AckAll((struct rxevent *)0, call, 0);
 		    }