From: Jeffrey Altman Date: Thu, 7 Jul 2011 21:51:58 +0000 (-0400) Subject: Windows: cm_BkgDaemon should not do cm_SyncOp's job X-Git-Tag: upstream/1.6.0^2~61 X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=cf11acc2fd82170f891042ad945f94ec7ea8bb6b;p=packages%2Fo%2Fopenafs.git Windows: cm_BkgDaemon should not do cm_SyncOp's job cm_SyncOp is designed to synchronize operations among multiple threads. The background daemon threads should not filter requests based upon cm_SyncOp states. Doing so is racy and does not produce better performance. Reviewed-on: http://gerrit.openafs.org/5119 Tested-by: BuildBot Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman (cherry picked from 7e3615208d9e1b03d8eba4fb802744b2b81f8868) Change-Id: I2293643bf708c3e87093005d95c7d1203c6f680a Reviewed-on: http://gerrit.openafs.org/5145 Tested-by: BuildBot Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman --- diff --git a/src/WINNT/afsd/cm_daemon.c b/src/WINNT/afsd/cm_daemon.c index 1a158bd9e..4f809f578 100644 --- a/src/WINNT/afsd/cm_daemon.c +++ b/src/WINNT/afsd/cm_daemon.c @@ -114,8 +114,7 @@ void cm_BkgDaemon(void * parm) /* we found a request */ for (rp = cm_bkgListEndp; rp; rp = (cm_bkgRequest_t *) osi_QPrev(&rp->q)) { - if (!(rp->scp->flags & CM_SCACHEFLAG_DATASTORING) && - cm_ServerAvailable(&rp->scp->fid, rp->userp)) + if (cm_ServerAvailable(&rp->scp->fid, rp->userp)) break; } if (rp == NULL) {