From: Hans-Werner Paulsen <hans@MPA-Garching.MPG.DE>
Date: Fri, 9 Nov 2012 12:48:45 +0000 (+0100)
Subject: fileserver: check value of -cb argument
X-Git-Tag: upstream/1.8.0_pre1^2~1827
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=d2d3c51a7d76c41b154105c5295eeee172c573ae;p=packages%2Fo%2Fopenafs.git

fileserver: check value of -cb argument

The value of the -cb argument for the fileserver was not checked correctly.
The fileserver refused to start for any number of callbacks.

Change-Id: I25fe9d81ba20d286f36999a554c94fda4ef7fb2f
Reviewed-on: http://gerrit.openafs.org/8420
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
---

diff --git a/src/viced/viced.c b/src/viced/viced.c
index 457fdec44..cd5c23075 100644
--- a/src/viced/viced.c
+++ b/src/viced/viced.c
@@ -1216,9 +1216,11 @@ ParseArgs(int argc, char *argv[])
     cmd_OptionAsInt(opts, OPT_buffers, &buffs);
 
     if (cmd_OptionAsInt(opts, OPT_callbacks, &numberofcbs) == 0) {
-	printf("number of cbs %d invalid; "
-	       "must be between 10000 and 2147483647\n", numberofcbs);
-	return -1;
+	if ((numberofcbs < 10000) || (numberofcbs > 2147483647)) {
+	    printf("number of cbs %d invalid; "
+		   "must be between 10000 and 2147483647\n", numberofcbs);
+	    return -1;
+	}
     }
 
     cmd_OptionAsInt(opts, OPT_vcsize, &volcache);