From: Jeffrey Altman <jaltman@secure-endpoints.com>
Date: Thu, 11 Sep 2008 18:03:52 +0000 (+0000)
Subject: windows-cell-list-validation-20080911
X-Git-Tag: openafs-devel-1_5_61~829
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=d85bdb4c9f9ddf7d287072a3d12e65423e551f40;p=packages%2Fo%2Fopenafs.git

windows-cell-list-validation-20080911

LICENSE MIT

correct cell list validation now that the free cell list exists
---

diff --git a/src/WINNT/afsd/cm_cell.c b/src/WINNT/afsd/cm_cell.c
index 67a4ef67f..8d8264330 100644
--- a/src/WINNT/afsd/cm_cell.c
+++ b/src/WINNT/afsd/cm_cell.c
@@ -399,10 +399,19 @@ cm_ValidateCell(void)
         }
     }
 
+    for (cellp = cm_data.freeCellsp; cellp; cellp=cellp->freeNextp, count++) {
+        if ( count != 0 && cellp == cm_data.freeCellsp ||
+             count > cm_data.maxCells ) {
+            afsi_log("cm_ValidateCell failure: cm_data.freeCellsp infinite loop");
+            fprintf(stderr, "cm_ValidateCell failure: cm_data.freeCellsp infinite loop\n");
+            return -3;
+        }
+    }
+
     if ( count != cm_data.currentCells ) {
         afsi_log("cm_ValidateCell failure: count != cm_data.currentCells");
         fprintf(stderr, "cm_ValidateCell failure: count != cm_data.currentCells\n");
-        return -3;
+        return -4;
     }
     
     return 0;