From: Jeffrey Altman <jaltman@your-file-system.com>
Date: Tue, 21 Jan 2014 09:19:28 +0000 (-0500)
Subject: Windows: AFSEvaluateTargetByName NULL ptr assignment
X-Git-Tag: upstream/1.8.0_pre1^2~596
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=d93b89ddb61d44b47f039ae96af6304f2d87b5e2;p=packages%2Fo%2Fopenafs.git

Windows: AFSEvaluateTargetByName NULL ptr assignment

If DirEnumEntry is NULL, then on failure of AFSEvaluateTargetByName()
a NULL pointer will be dereferenced prior to function return.

Change-Id: I6d0d646e667c4b805abcddce1af49b81037ae51d
Reviewed-on: http://gerrit.openafs.org/11422
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
---

diff --git a/src/WINNT/afsrdr/kernel/lib/AFSCommSupport.cpp b/src/WINNT/afsrdr/kernel/lib/AFSCommSupport.cpp
index 858aba0c8..f912cea58 100644
--- a/src/WINNT/afsrdr/kernel/lib/AFSCommSupport.cpp
+++ b/src/WINNT/afsrdr/kernel/lib/AFSCommSupport.cpp
@@ -3024,7 +3024,11 @@ try_exit:
                 AFSExFreePoolWithTag( pDirEnumCB, AFS_GENERIC_MEMORY_3_TAG);
             }
 
-            *DirEnumEntry = NULL;
+	    if( DirEnumEntry != NULL)
+	    {
+
+		*DirEnumEntry = NULL;
+	    }
         }
     }