From: Jacob Thebault-Spieker <summatusmentis@gmail.com>
Date: Tue, 19 Jul 2011 16:02:49 +0000 (-0700)
Subject: remove check for disallowing clones of backup or ro volumes
X-Git-Tag: upstream/1.6.1.pre1^2~161
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=da78610b266a04bee6674339300495a7ad21f015;p=packages%2Fo%2Fopenafs.git

remove check for disallowing clones of backup or ro volumes

removes the if-statement ensuring that the volume being cloned is
not a backup volume, nor a read-only volume. This allows clones
from any type of volume to a given volume. Parent volume meta-data
is maintained, only the cloneId value changes.

Reviewed-on: http://gerrit.openafs.org/5046
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
(cherry picked from commit 4e1a65ba7edec519acc67f0dcf2237a0f26e92aa)

Change-Id: Ibda6a8a12804fc35890c99ada6d711e25a50a6c8
Reviewed-on: http://gerrit.openafs.org/5724
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
Tested-by: Derrick Brashear <shadow@dementix.org>
---

diff --git a/src/volser/volprocs.c b/src/volser/volprocs.c
index 13ad8dc3c..46f1e8aec 100644
--- a/src/volser/volprocs.c
+++ b/src/volser/volprocs.c
@@ -904,12 +904,6 @@ VolReClone(struct rx_call *acid, afs_int32 atrans, afs_int32 cloneId)
     TSetRxCall(tt, acid, "ReClone");
 
     originalvp = tt->volume;
-    if ((V_type(originalvp) == backupVolume)
-	|| (V_type(originalvp) == readonlyVolume)) {
-	Log("1 Volser: Clone: The volume to be cloned must be a read/write; aborted\n");
-	error = EROFS;
-	goto fail;
-    }
     if ((V_destroyMe(originalvp) == DESTROY_ME) || !V_inService(originalvp)) {
 	Log("1 Volser: Clone: Volume %d is offline and cannot be cloned\n",
 	    V_id(originalvp));