From: Derrick Brashear <shadow@dementia.org>
Date: Tue, 24 Mar 2009 22:40:14 +0000 (+0000)
Subject: DEVEL15-shutdown-vcache-avoid-null-deref-20090324
X-Git-Tag: openafs-devel-1_5_58~8
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=df46bd2b92036b4a107e8dba94cd23944dd18921;p=packages%2Fo%2Fopenafs.git

DEVEL15-shutdown-vcache-avoid-null-deref-20090324

LICENSE IPL10

avoid potential null pointer deref at shutdown


(cherry picked from commit 4162ff9d4d733afc788b3c002adc57aac78a3282)
---

diff --git a/src/afs/afs_vcache.c b/src/afs/afs_vcache.c
index e0f7e0c10..593d7fc39 100644
--- a/src/afs/afs_vcache.c
+++ b/src/afs/afs_vcache.c
@@ -3286,7 +3286,7 @@ shutdown_vcache(void)
      */
 
     {
-	register struct afs_q *tq, *uq;
+	register struct afs_q *tq, *uq = NULL;
 	register struct vcache *tvc;
 	for (tq = VLRU.prev; tq != &VLRU; tq = uq) {
 	    tvc = QTOV(tq);
@@ -3341,7 +3341,8 @@ shutdown_vcache(void)
 		    tvc->linkData = 0;
 		}
 
-		afs_FreeAllAxs(&(tvc->Access));
+		if (tvc->Access)
+		    afs_FreeAllAxs(&(tvc->Access));
 	    }
 	    afs_vhashT[i] = 0;
 	}