From: Simon Wilkinson <sxw@your-file-system.com>
Date: Thu, 21 Feb 2013 20:53:02 +0000 (+0000)
Subject: bosserver: Remove dead assignment in SaveOldFiles
X-Git-Tag: upstream/1.8.0_pre1^2~1448
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=e28294a9def87b306be1e99c4eebdb86bd138405;p=packages%2Fo%2Fopenafs.git

bosserver: Remove dead assignment in SaveOldFiles

We don't care about whether the renames succeed in SaveOldFiles,
so don't bother assigning their results to a variable

Caught by clang-analyzer

Change-Id: I0605fc71d243ef0f587706f9f3856aa4d722fb82
Reviewed-on: http://gerrit.openafs.org/9207
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
---

diff --git a/src/bozo/bosoprocs.c b/src/bozo/bosoprocs.c
index 18c1bdee7..e90c6024f 100644
--- a/src/bozo/bosoprocs.c
+++ b/src/bozo/bosoprocs.c
@@ -252,7 +252,7 @@ SaveOldFiles(char *aname)
 
     if (bakTime && (oldTime == 0 || bakTime < now - BOZO_OLDTIME)) {
 	/* no .OLD file, or .BAK is at least a week old */
-	code = rk_rename(bbuffer, obuffer);
+	rk_rename(bbuffer, obuffer);
     }
 
     /* finally rename to .BAK extension */