From: Simon Wilkinson <sxw@your-file-system.com>
Date: Sun, 24 Feb 2013 10:39:53 +0000 (+0000)
Subject: butc: Catch failures to start keep alive thread
X-Git-Tag: upstream/1.8.0_pre1^2~1435
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=e4862e284832420e9dbf5a6f437f6f7c8801f7dd;p=packages%2Fo%2Fopenafs.git

butc: Catch failures to start keep alive thread

If we can't start the keep alive thread, in either the LWP or
pthread versions of a code, report an error and exit instead of
carrying on regardless.

Caught by clang-analyzer

Change-Id: I0a25a236aadeedf10d3c0c129d716b1397c9a4e3
Reviewed-on: http://gerrit.openafs.org/9245
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
---

diff --git a/src/butc/tcudbprocs.c b/src/butc/tcudbprocs.c
index 5bb0ca148..322c61765 100644
--- a/src/butc/tcudbprocs.c
+++ b/src/butc/tcudbprocs.c
@@ -493,7 +493,11 @@ writeDbDump(struct butm_tapeInfo *tapeInfoPtr, afs_uint32 taskId,
 		    LWP_CreateProcess(KeepAlive, 16384, 1, NULL,
 				      "Keep-alive process", &alivePid);
 #endif
-		/* XXX should we check code here ??? XXX */
+		if (code) {
+		    ErrorLog(0, taskId, code, 0,
+			     "Failed to create keep alive process\n");
+		    ERROR_EXIT(code);
+		}
 	    }
 	    firstcall = 0;