From: Perry Ruiter <pruiter@sinenomine.net>
Date: Fri, 30 May 2014 21:28:53 +0000 (-0700)
Subject: audit: Delete va_copy kludge
X-Git-Tag: upstream/1.8.0_pre1^2~672
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=e7a4359a0870f214091113f3efb0b32a4b68663c;p=packages%2Fo%2Fopenafs.git

audit: Delete va_copy kludge

When I developed fix c3d4c109305b2db8a63b754c1894ad37326dc340 I used
va_copy.  I was nervous because it required C99, but I had no
problem with any of the buildbots, nor did any reviewer comment.
audit/audit.c contains a local hack to simulate va_copy in the
pre C99 days.  There are no uses of va_copy in audit.c but
presumably at some point there was.  Delete the local va_copy.

Change-Id: I5e30c7e3052aeffe56e366888c5a3db3a705fd00
Reviewed-on: http://gerrit.openafs.org/11184
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: D Brashear <shadow@your-file-system.com>
---

diff --git a/src/audit/audit.c b/src/audit/audit.c
index 327b89cdd..32978432b 100644
--- a/src/audit/audit.c
+++ b/src/audit/audit.c
@@ -32,16 +32,6 @@
 
 #include <afs/afsutil.h>
 
-/* C99 requires va_copy.  Older versions of GCC provide __va_copy.  Per t
-   Autoconf manual, memcpy is a generally portable fallback. */
-#ifndef va_copy
-# ifdef __va_copy
-#  define va_copy(d, s)         __va_copy((d), (s))
-# else
-#  define va_copy(d, s)         memcpy(&(d), &(s), sizeof(va_list))
-# endif
-#endif
-
 extern struct osi_audit_ops audit_file_ops;
 #ifdef HAVE_SYS_IPC_H
 extern struct osi_audit_ops audit_sysvmq_ops;