From: Garrett Wollman Date: Sat, 13 Aug 2011 23:12:50 +0000 (-0400) Subject: libafs: don't free the NULL we get from a failed allocation X-Git-Tag: upstream/1.8.0_pre1^2~3395 X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=ee56107d4d168ef07968afeaa7f1c5b39f5c5b23;p=packages%2Fo%2Fopenafs.git libafs: don't free the NULL we get from a failed allocation In extractPioctlToken(), if we fail to allocate space for token_opaque_val, don't immediately pass the null pointer to osi_Free on the error exit path. Change-Id: Ic95e178cfbc1b1bbcb18701c0bbd5221426342ee Found-by: clang static analyzer with help from AFS_NONNULL Reviewed-on: http://gerrit.openafs.org/5262 Tested-by: BuildBot Reviewed-by: Derrick Brashear --- diff --git a/src/afs/afs_tokens.c b/src/afs/afs_tokens.c index 1b8879035..2dc4c3074 100644 --- a/src/afs/afs_tokens.c +++ b/src/afs/afs_tokens.c @@ -453,7 +453,8 @@ out: osi_Free(pioctlToken, sizeof(struct ktc_tokenUnion)); if (code != 0) { - osi_Free(opaque->token_opaque_val, opaque->token_opaque_len); + if (opaque->token_opaque_val != NULL) + osi_Free(opaque->token_opaque_val, opaque->token_opaque_len); opaque->token_opaque_val = NULL; opaque->token_opaque_len = 0; }