From: Stephan Wiesand Date: Fri, 30 May 2014 13:05:28 +0000 (+0200) Subject: libadmin: Remove redundant memset call X-Git-Tag: upstream/1.8.0_pre1^2~671 X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=f05abc47938beddb436fd0b9677f7b59fc64a215;p=packages%2Fo%2Fopenafs.git libadmin: Remove redundant memset call Commit bf78bf2c115659b78c34d3bc9d1934bcff21c8cc added initialisation of the nbulkentries structure to 0, to avoid freeing garbage due to a goto fail_... before the structure is initialised. As pointed out by Andrew Deason, there already is an equivalent memset call later in the code which is now redundant. Remove it. Change-Id: I236e6de2a79f4f483be314654225bd52316f5a02 Reviewed-on: http://gerrit.openafs.org/11180 Reviewed-by: Jeffrey Altman Tested-by: BuildBot --- diff --git a/src/libadmin/vos/afs_vosAdmin.c b/src/libadmin/vos/afs_vosAdmin.c index 12b116445..dfcef7f7b 100644 --- a/src/libadmin/vos/afs_vosAdmin.c +++ b/src/libadmin/vos/afs_vosAdmin.c @@ -372,8 +372,6 @@ vos_BackupVolumeCreateMultiple(const void *cellHandle, prefix_len = strlen(volumePrefix); } - memset((void *)&arrayEntries, 0, sizeof(arrayEntries)); - /* * Get a list of all the volumes in the cell */