From: Jeffrey Altman Date: Sat, 3 Dec 2011 20:45:53 +0000 (-0500) Subject: rx: rx_conn/rx_peer refCount signed X-Git-Tag: upstream/1.8.0_pre1^2~2971 X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=f37df60763a306fb70f791f7dcba9cec2ec27c7e;p=packages%2Fo%2Fopenafs.git rx: rx_conn/rx_peer refCount signed Can't trace reference count underflows with rxi_LowConnRefCount and rxi_LowPeerRefCount if they cannot become negative. Change-Id: I429da00a8e711c2e562378ec5d6601093293a55b Reviewed-on: http://gerrit.openafs.org/6205 Tested-by: BuildBot Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman --- diff --git a/src/rx/rx.h b/src/rx/rx.h index 50d2bf28b..97a9f493c 100644 --- a/src/rx/rx.h +++ b/src/rx/rx.h @@ -256,7 +256,7 @@ struct rx_connection { /* client-- to retransmit the challenge */ struct rx_service *service; /* used by servers only */ u_short serviceId; /* To stamp on requests (clients only) */ - afs_uint32 refCount; /* Reference count (rx_refcnt_mutex) */ + afs_int32 refCount; /* Reference count (rx_refcnt_mutex) */ u_char flags; /* Defined below - (conn_data_lock) */ u_char type; /* Type of connection, defined below */ u_char secondsUntilPing; /* how often to ping for each active call */ @@ -384,7 +384,7 @@ struct rx_peer { /* For garbage collection */ afs_uint32 idleWhen; /* When the refcountwent to zero */ - afs_uint32 refCount; /* Reference count for this structure (rx_peerHashTable_lock) */ + afs_int32 refCount; /* Reference count for this structure (rx_peerHashTable_lock) */ /* Congestion control parameters */ u_char burstSize; /* Reinitialization size for the burst parameter */