From: Simon Wilkinson Date: Thu, 23 Sep 2010 16:41:47 +0000 (+0100) Subject: rx: Big windows make us sad X-Git-Tag: openafs-devel-1_5_78~116 X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=f74abfb4d0b8d354a0ce3abf60c4da6e0ac4e14c;p=packages%2Fo%2Fopenafs.git rx: Big windows make us sad The commit which took our Window size to 128 caused rxperf to run 40 times slower than before. All of the recent rx improvements have reduced this to being around 2x slower than before, but we're still not ready for large window sizes. As 1.6 is nearing release, reset back to the old, fast, window size of 32. We can revist this as further performance improvements and restructuring happen on master. Reviewed-on: http://gerrit.openafs.org/2844 Tested-by: BuildBot Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman (cherry picked from commit a99e616d445d8b713934194ded2e23fe20777f9a) Change-Id: I6080c69ba51c8743b8c48bf0e0b7dd481185688d Reviewed-on: http://gerrit.openafs.org/2922 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear --- diff --git a/src/rx/rx_globals.h b/src/rx/rx_globals.h index e24078b6b..a6d02e613 100644 --- a/src/rx/rx_globals.h +++ b/src/rx/rx_globals.h @@ -128,9 +128,9 @@ EXT int rx_minPeerTimeout GLOBALSINIT(2); /* in milliseconds */ EXT int rx_minWindow GLOBALSINIT(1); EXT int rx_maxWindow GLOBALSINIT(65535); /* twind is u_short */ EXT int rx_initReceiveWindow GLOBALSINIT(16); /* how much to accept */ -EXT int rx_maxReceiveWindow GLOBALSINIT(128); /* how much to accept */ +EXT int rx_maxReceiveWindow GLOBALSINIT(32); /* how much to accept */ EXT int rx_initSendWindow GLOBALSINIT(16); -EXT int rx_maxSendWindow GLOBALSINIT(128); +EXT int rx_maxSendWindow GLOBALSINIT(32); EXT int rx_nackThreshold GLOBALSINIT(3); /* Number NACKS to trigger congestion recovery */ EXT int rx_nDgramThreshold GLOBALSINIT(4); /* Number of packets before increasing * packets per datagram */