From: Jeffrey Hutzelman <jhutz@cs.cmu.edu>
Date: Tue, 20 Jun 2006 21:03:16 +0000 (+0000)
Subject: DEVEL15-viced-findclient-do-not-return-wrong-client-20060620
X-Git-Tag: openafs-devel-1_5_3~54
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=f8417b5f6370b15d5dab745bd75d2bc58be56046;p=packages%2Fo%2Fopenafs.git

DEVEL15-viced-findclient-do-not-return-wrong-client-20060620


In h_FindClient_r it was possible for the wrong client to be returned
and worse for it to be returned without the reference count being
incremented.


(cherry picked from commit 06fa1f9c40432747724e6e55154bf54e1e3e94c5)
---

diff --git a/src/viced/host.c b/src/viced/host.c
index 41f204092..335ab97cc 100644
--- a/src/viced/host.c
+++ b/src/viced/host.c
@@ -1645,6 +1645,8 @@ h_FindClient_r(struct rx_connection *tcon)
 	H_UNLOCK;
 	ObtainWriteLock(&client->lock);	/* released at end */
 	H_LOCK;
+    } else {
+	client = NULL;
     }
 
     authClass = rx_SecurityClassOf((struct rx_connection *)tcon);