From: Simon Wilkinson <sxw@your-file-system.com>
Date: Tue, 19 Feb 2013 16:31:28 +0000 (+0000)
Subject: rxkad: Remove redundant checkCksum initialisation
X-Git-Tag: upstream/1.8.0_pre1^2~1465
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=f9eab19d82a99b1bbec2b66b42c9eb81dbbe7f97;p=packages%2Fo%2Fopenafs.git

rxkad: Remove redundant checkCksum initialisation

checkCksum is assigned to by both sides of the if() expression, so
there's no need to initialise it to 0.

Caught by clang-analyzer

Change-Id: Id0e286943e11b6948231577085cdb0ce96bb0b97
Reviewed-on: http://gerrit.openafs.org/9183
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
---

diff --git a/src/rxkad/rxkad_common.c b/src/rxkad/rxkad_common.c
index 484909df3..3133d2928 100644
--- a/src/rxkad/rxkad_common.c
+++ b/src/rxkad/rxkad_common.c
@@ -430,7 +430,6 @@ rxkad_CheckPacket(struct rx_securityClass *aobj, struct rx_call *acall,
 
     tconn = rx_ConnectionOf(acall);
     len = rx_GetDataSize(apacket);
-    checkCksum = 0;		/* init */
     if (rx_IsServerConn(tconn)) {
 	struct rxkad_sconn *sconn;
 	sconn = rx_GetSecurityData(tconn);