From: Marc Dionne <marc.c.dionne@gmail.com>
Date: Sun, 4 Oct 2009 17:40:10 +0000 (-0400)
Subject: rxfs_storePadd: return 0 on success
X-Git-Tag: openafs-devel-1_5_66~123
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=fa8766d220e37d5c11fc6ac72e3de40f5054cfff;p=packages%2Fo%2Fopenafs.git

rxfs_storePadd: return 0 on success

On success, storePadd should return 0, not the number of bytes
written by the last rx_Write call.  In some cases this return
value would leak all the way out to the close() system call,
causing it to fail.

Reviewed-on: http://gerrit.openafs.org/573
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
---

diff --git a/src/afs/afs_fetchstore.c b/src/afs/afs_fetchstore.c
index a6357069d..f94ad9eab 100644
--- a/src/afs/afs_fetchstore.c
+++ b/src/afs/afs_fetchstore.c
@@ -213,7 +213,7 @@ rxfs_storePadd(void *rock, afs_uint32 size)
 	    return -33;	/* XXX */
 	size -= tlen;
     }
-    return code;
+    return 0;
 }
 
 afs_int32