From: Jeffrey Altman <jaltman@your-file-system.com>
Date: Sun, 15 Jun 2014 02:58:52 +0000 (-0400)
Subject: Windows: registry enum do not request write perm
X-Git-Tag: upstream/1.8.0_pre1^2~598
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=fc70e0ddebb8521a69aaeb6e1d249b9ca577db52;p=packages%2Fo%2Fopenafs.git

Windows: registry enum do not request write perm

Only Read and Query privileges are required to enumerate the registry
keys, do not request write privileges for an enumeration.

Change-Id: Ifc9acb4203db71b6e94bf5a21ca5aa104d94d35b
Reviewed-on: http://gerrit.openafs.org/11416
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
---

diff --git a/src/WINNT/afsd/cm_config.c b/src/WINNT/afsd/cm_config.c
index 41cec8dd7..b071d6e06 100644
--- a/src/WINNT/afsd/cm_config.c
+++ b/src/WINNT/afsd/cm_config.c
@@ -840,15 +840,16 @@ long cm_EnumerateCellRegistry(afs_uint32 client, cm_enumCellProc_t *procp, void
     LONG code;
     FILETIME ftLastWriteTime;
     char szCellName[CELL_MAXNAMELEN];
+	char * subkey = AFSREG_CLT_OPENAFS_SUBKEY "\\CellServDB";
 
     /* No server CellServDB in the registry. */
     if (!client || procp == NULL)
         return 0;
 
     if (RegOpenKeyEx( HKEY_LOCAL_MACHINE,
-                      AFSREG_CLT_OPENAFS_SUBKEY "\\CellServDB",
+		      subkey,
                       0,
-                      KEY_READ|KEY_WRITE|KEY_QUERY_VALUE,
+		      KEY_READ|KEY_QUERY_VALUE,
                       &hkCellServDB) != ERROR_SUCCESS)
         return 0;