From: Simon Wilkinson <sxw@your-file-system.com>
Date: Sat, 2 Mar 2013 10:27:47 +0000 (+0000)
Subject: util: Avoid overflow in GetNameByINet
X-Git-Tag: upstream/1.8.0_pre1^2~1337
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=fcb7974b838c2b37a8b81b88b11905c6ece398f6;p=packages%2Fo%2Fopenafs.git

util: Avoid overflow in GetNameByINet

We copy the results of gethostbyaddr into a fixed length buffer
without checking whether they fit. Add a length check, and use
strlcpy to do the copy to make sure we can't overflow.

Caught by coverity (#985912, #985872)

Change-Id: I1e8f0fbb2577199c25201940f54646a4acdbbd37
Reviewed-on: http://gerrit.openafs.org/9393
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
---

diff --git a/src/util/hostparse.c b/src/util/hostparse.c
index 4644a97fd..51c4bfb7c 100644
--- a/src/util/hostparse.c
+++ b/src/util/hostparse.c
@@ -104,8 +104,8 @@ hostutil_GetNameByINet(afs_uint32 addr)
 	return NULL;
 #endif
     th = gethostbyaddr((void *)&addr, sizeof(addr), AF_INET);
-    if (th) {
-	strcpy(tbuffer, th->h_name);
+    if (th && strlen(th->h_name) < sizeof(tbuffer)) {
+	strlcpy(tbuffer, th->h_name, sizeof(tbuffer));
     } else {
 	addr = ntohl(addr);
 	sprintf(tbuffer, "%d.%d.%d.%d", (int)((addr >> 24) & 0xff),