From: Jeffrey Altman <jaltman@secure-endpoints.com>
Date: Sat, 18 Oct 2008 16:24:45 +0000 (+0000)
Subject: DEVEL15-ubik-uninitialized-var-20081018
X-Git-Tag: openafs-devel-1_5_55~40
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=fe6399e9eb09a376097d19871c362eaf72db90c2;p=packages%2Fo%2Fopenafs.git

DEVEL15-ubik-uninitialized-var-20081018

LICENSE MIT

'pass' must be initialized.  do so.


(cherry picked from commit 7e8c41d53fcd51ae0ff4420ba1027b354af306c8)
---

diff --git a/src/ubik/recovery.c b/src/ubik/recovery.c
index 9b76e0d3b..ae3a7ee40 100644
--- a/src/ubik/recovery.c
+++ b/src/ubik/recovery.c
@@ -605,6 +605,7 @@ urecovery_Interact(void *dummy)
 	    }
 #endif
 
+	    pass = 0;
 	    while (length > 0) {
 		tlen = (length > sizeof(tbuffer) ? sizeof(tbuffer) : length);
 #ifndef AFS_PTHREAD_ENV
diff --git a/src/ubik/remote.c b/src/ubik/remote.c
index 2ed2a29e8..c30bb0cf8 100644
--- a/src/ubik/remote.c
+++ b/src/ubik/remote.c
@@ -560,7 +560,6 @@ SDISK_SendFile(rxcall, file, length, avers)
 	close(fd);
 	goto failed;
     }
-#else
     pass = 0;
 #endif
     memcpy(&ubik_dbase->version, &tversion, sizeof(struct ubik_version));