From: Jeffrey Altman <jaltman@secure-endpoints.com>
Date: Sat, 7 Oct 2006 23:27:14 +0000 (+0000)
Subject: windows-scache-ref-leak-20061007
X-Git-Tag: BP-openafs-windows-kdfs-ifs~1008
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=feb5f27c754325dcc5fd9eb13f305bc1c0172977;p=packages%2Fo%2Fopenafs.git

windows-scache-ref-leak-20061007


return the cm_scache_t whose refCount was increased
---

diff --git a/src/WINNT/afsd/cm_scache.c b/src/WINNT/afsd/cm_scache.c
index 76b8a89af..2d489e120 100644
--- a/src/WINNT/afsd/cm_scache.c
+++ b/src/WINNT/afsd/cm_scache.c
@@ -765,15 +765,15 @@ cm_scache_t * cm_FindSCacheParent(cm_scache_t * scp)
     parent_fid.unique = scp->parentUnique;
 
     if (cm_FidCmp(&scp->fid, &parent_fid)) {
-	for (i=0; i<cm_data.hashTableSize; i++) {
-	    for (pscp = cm_data.hashTablep[i]; pscp; pscp = pscp->nextp) {
-		if (!cm_FidCmp(&pscp->fid, &parent_fid)) {
-		    cm_HoldSCacheNoLock(pscp);
-		    break;
-		}
+	i = CM_SCACHE_HASH(&parent_fid);
+	for (pscp = cm_data.hashTablep[i]; pscp; pscp = pscp->nextp) {
+	    if (!cm_FidCmp(&pscp->fid, &parent_fid)) {
+		cm_HoldSCacheNoLock(pscp);
+		break;
 	    }
 	}
     }
+
     lock_ReleaseRead(&cm_scacheLock);
 
     return pscp;