git.michaelhowe.org Git - packages/o/openafs.git/log

rx idledeadtime don't track window wait

if we're in writer mode and waiting for more window, don't consider it idle.

Change-Id: Id1e80f297929eef363ffe88bfe181b74bb331515
Reviewed-on: http://gerrit.openafs.org/1182
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit d52213fcc5dae5095d660e1861f77e90c07bb2ab)
Reviewed-on: http://gerrit.openafs.org/1183

linux mmap anti-deadlock should issue error rather than write returns

we are careful to issue errors negative everywhere but here. do so
here also

Change-Id: I2322ffbaf16c91161d0d7aa980d50f56b83ac0a2
Reviewed-on: http://gerrit.openafs.org/1137
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

Enable weak enctypes for klog.krb5 if supported by Kerberos

The same as cb4b62a40352ccebae3a299f4327fa70fc7a0c5c, but for klog.krb5.

Current versions of both MIT Kerberos and Heimdal disable DES enctypes
by default, but DES enctypes are still required for AFS service tickets.
Probe for either krb5_allow_weak_crypto() (MIT Kerberos 1.8) or
krb5_enctype_enable() (Heimdal) and, if found, call them to enable DES
enctypes. If neither is found, assume that the Kerberos libraries are
old enough that DES is enabled by default.

Change-Id: I99c93621c847f6edcc485207f5b6b99b2370b347
Reviewed-on: http://gerrit.openafs.org/1144
Tested-by: Russ Allbery <rra@stanford.edu>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit f02ab3339d01bca414fe705f3a990a1db146f29b)
Reviewed-on: http://gerrit.openafs.org/1148
Tested-by: Derrick Brashear <shadow@dementia.org>

Enable weak enctypes for aklog if supported by Kerberos

Current versions of both MIT Kerberos and Heimdal disable DES enctypes
by default, but DES enctypes are still required for AFS service tickets.
Probe for either krb5_allow_weak_crypto() (MIT Kerberos 1.8) or
krb5_enctype_enable() (Heimdal) and, if found, call them to enable DES
enctypes. If neither is found, assume that the Kerberos libraries are
old enough that DES is enabled by default.

Change-Id: Ib5231bb7c2fe88f4c424628394ed08122d5710a1
Reviewed-on: http://gerrit.openafs.org/1141
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit cb4b62a40352ccebae3a299f4327fa70fc7a0c5c)
Reviewed-on: http://gerrit.openafs.org/1145
Tested-by: Russ Allbery <rra@stanford.edu>

Don't double free call structure

If the rx_Read() of the number of bytes in the FetchData64 response
fails, then it sets code, and disposes of the call structure. However,
the length safety check that was added in
c7b92a3018044f7aca4d9a77644e5c06ef64d1e9 executes regardless of whether
code is set, and the call has already been freed. So we end up calling
rx_Error with a NULL call structure, and panic.

(pulled up from 806423be3c55f3de91c2b836d2088eeb0f4e4665)

Change-Id: Ia1ee4ab9c794db9337e4eb7b5b5980c8a57cef0b
Reviewed-on: http://gerrit.openafs.org/1113
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

Spec file changes

RedHat spec file changes so that the current tree will build into
RPMS.

Change-Id: Id7fa677e2ff8fac3ce0fee876b1274bc65e944fb
Reviewed-on: http://gerrit.openafs.org/1102
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

Don't install compile_et into its own directory

When pinstall sees that the basenames of its two arguments differ,
it assumes that its installing into a path, and creates the missing
directory. This meant that we got /usr/bin/afs_compile_et/compile_et
which wasn't the desired result.

Change-Id: Ie6af2d3fd9c5166dd2d884c22d287c180b24fab1
Reviewed-on: http://gerrit.openafs.org/1099
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

Linux: kmem_cache_create fix and cleanup

Fix the kmem_cache constructor function to match the current
expected prototype, and cleanup related code. This has been wrong
for a while, but since we were just passing extra parameters the
only effect was to generate a warning.

- Add a new configure test to detect the new constructor function
signature
- Define the older versions of the constructor in osi_compat.h,
making them call the current version
- Move a few compatibility #defines to osi_compat.h

(cherry picked from 3abc87a5a94f0d5eaca702c7bd66fbe35ce7b896)
Reviewed-on: http://gerrit.openafs.org/657
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Change-Id: I3570a3268d35ac73409b96816ba5112f809f6645
Reviewed-on: http://gerrit.openafs.org/994
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

make 1.4.12rc1

mark the first 1.4.12 release candidate

Change-Id: Ief73a61978469f142c0305246fa8224b8a842f58
Reviewed-on: http://gerrit.openafs.org/1091
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

linux kernel lacks uintptr

sadly only recent kernels include uintptr_t. change the cast to use unsigned
long

Change-Id: Ib69f7aa0f2d316c5ea8bdc960b15ee0f89f96250
Reviewed-on: http://gerrit.openafs.org/1059
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 165571947be770645900bb8d55ba7b6a3c58f8fd)
Reviewed-on: http://gerrit.openafs.org/1081

avoid leaking stat info

if a file is already CStatd we just copy out the information without doing
access checks. add an access check.

Reviewed-on: http://gerrit.openafs.org/995
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 6ec18461649d3e4f44b2476f886bcc480c456500)

Change-Id: I4a66c9e4229da464592c1dad94854261e5daa30d
Reviewed-on: http://gerrit.openafs.org/1076
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

viced host always hash on add

currently the openafs 1.4 code doesn't always add a host/port pair to the
hash when an interface address is being added. make the code match what exists
on the head

Change-Id: Ibf56a397b936abd1b0646c63c5dda88a59819538
Reviewed-on: http://gerrit.openafs.org/1053
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Alistair Ferguson <alistair.ferguson@mac.com>
Tested-by: Alistair Ferguson <alistair.ferguson@mac.com>
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Tested-by: Michael Meffie <mmeffie@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

viced: add then remove when changing addresses

When changing a host address, be sure to add the new interface
before removing the old to avoid having the host marked as
deleted if we removed the only valid address. This change was
pulled out of commit ca613599a2537756462a420ae1a632747a433226
viced-host-uuid-and-addr-hashing-corrections-20090530 by
Jeffrey Altman.

LICENSE IPL10
FIXES 124634

Change-Id: Ie65e762c4be6205eb654566403f0d5088b7ebdee
Reviewed-on: http://gerrit.openafs.org/1026
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

Shout less about system call hooks when using keyrings

When keyrings are in use, the user doesn't really care whether or
not we manage to hook the system call table, and the current message
has proved confusing, as it seems to indicate something has gone wrong.

Tone down the warning that's produced when keyrings are in use. This is
1.4.x only, as we're going to completely disable system call probes when
keyrings are in use in 1.5.x

FIXES 125215

Change-Id: I60bbe852d11f2f0c9546b30c877f5ff27d05e7fb
Reviewed-on: http://gerrit.openafs.org/1024
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

Linux: deal with ctl_name removal

The binary sysctl interface will be removed in kernel 2.6.33 and
ctl_name will be dropped from the ctl_table structure.
Make the code that uses ctl_name conditional on a configure test.

(cherry picked from commit 886801b069fab1e6fc94003221dcfe18e05ac376)

Change-Id: Iba0f107f299c6515e4e560d7596e6187bd68e399
Reviewed-on: http://gerrit.openafs.org/904
Tested-by: Marc Dionne <marc.c.dionne@gmail.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Reviewed-on: http://gerrit.openafs.org/1013
Tested-by: Derrick Brashear <shadow@dementia.org>

Backport casting from origin/master to origin/openafs-stable-1_4_x

The casting is necessary to make rpmlint happy when building SUSE rpms.

(cherry picked from b147521611a73d0578aca14b3252e062de1e5d8a)

Change-Id: I7e6c260e03891e81b8bafccb0f689cd423c40570
Reviewed-on: http://gerrit.openafs.org/1015
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

Linux: utsrelease.h is moving

In kernel 2.6.33, utsrelease.h has moved to include/generated.
Adapt the configure code to consider that location, and clean
up that section's indentation.

(cherry-picked from 36f97969f39637042a54c0d45877a48cc9dfcac1)

Change-Id: Ifb139aa8183740612fbb5e8dc06faf982fef9397
Reviewed-on: http://gerrit.openafs.org/1012
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

Linux: Flush vcaches when a mount fails

GetVCache (well, really NewVCache) creates a new vcache, with an attached
inode, and links it into the VLRU queue, regardless of whether it is
successful in populating that vcache or not. The attached inode, on Linux,
contains a reference to the super block of the filesystem. If the created
vcache is for the root, however, and populating that vcache failes, then mount
fails, and the super block is disposed of. This leaves us with a vcache in
the VLRU queue which contains a reference to a non-existent inode.

When ShakeLooseVCaches comes along a few minutes later, it attempts to discard
this inode. However, doing so fails because the inode no longer has a valid
super block.

Avoid this trauma by ensuring all vcaches are disposed of before the super
block goes away, in the event of a mount failure.

Change-Id: I68864f1ea401d24adba76164905a17de6ab3e6ce
Reviewed-on: http://gerrit.openafs.org/1003
Reviewed-by: Marc Dionne <marc.c.dionne@gmail.com>
Tested-by: Marc Dionne <marc.c.dionne@gmail.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from 994ef0e7cab95e2fc6f47fc8838490112e432ffd)
Reviewed-on: http://gerrit.openafs.org/1008
Tested-by: Derrick Brashear <shadow@dementia.org>

Do not trust FetchData length from fileservers

Currently the Unix CM implicitly trusts that the length from a FetchData
request from a fileserver will always be less than the requested length.
If the fileserver sends more data than requested, we can use up more
cache space than we intended, possibly exceeding the cacheinfo cache
limits.

Add a check for this, and return EIO to the caller if the fileserver
responds with too much data.

Reviewed-on: http://gerrit.openafs.org/996
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit c7b92a3018044f7aca4d9a77644e5c06ef64d1e9)

Change-Id: Ibbbc989cfb6522bb7d3c3003d31931549812d18e
Reviewed-on: http://gerrit.openafs.org/1002
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

Implementation of new dump tag and length standard

The implementation follows the specification from October 2007.

All old tags are accecpted as before.
New tags 0x06-0x60 (capital letters) are followed by a 1 byte length
field which may contain directly the length (up to 127) or the length
of the then following length field (max 8) ored with 0x80.
New tags 0x61-0x77a are directly followed by 4 bytes building a 32bit
integer.
0x7b-0xf are single-byte tags, 0x7e meaning next tag is critical.

On this basis unknown tags can be skipped unless they were marked
critical. In this case the restore is aborted.

in dump.h tags following the new standard are marked by an asterisk

Last update: added parameter types for HandleUnknownTag.

Reviewed-on: http://gerrit.openafs.org/191
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 3f2dd80697959f5922032f4d4a7c9ef0cfadf35c)
Change-Id: I9cb56bf2449a2bb9d906368af85acb3181149c95
Reviewed-on: http://gerrit.openafs.org/993

Add a watchdog timer for ShutDownAndCore(PANIC)

Add a watchdog timer that is started when ShutDownAndCore(PANIC) is
called, to ensure we actually panic and do not e.g. get stuck in
deadlock.

Reviewed-on: http://gerrit.openafs.org/873
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Alistair Ferguson <alistair.ferguson@mac.com>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 9bff2027cb963343778001512d5cdf00cc7094c6)

Change-Id: If91606ff50aa19a614edf51e274d055bb8b30618
Reviewed-on: http://gerrit.openafs.org/991
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

Add safety checks on all hostList traversals

Currently, h_Enumerate checks that it doesn't enumerate over more than
hostCount hosts, in case the hostList has a cycle or is otherwise
corrupt. Add similar checks to all places in the code that loop over
hostList, to prevent the code from getting in an infinite loop under
H_LOCK in the case of a hostList cycle.

Also, ShutDownAndCore instead of assert'ing, so we try and detach
volumes first, possibly reducing salvaging time when we restart after
core'ing.

(cherry picked from 58258ba3b89732ea825e1aff2decab54347ab92e)
Change-Id: Ide1e5aca7c2c4a4af3f62bc07821db694f2f9999
Reviewed-on: http://gerrit.openafs.org/863
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Alistair Ferguson <alistair.ferguson@mac.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-on: http://gerrit.openafs.org/990
Reviewed-by: Andrew Deason <adeason@sinenomine.net>

Rename installed version of compile_et

Rename the installed version of compile_et to afs_compile_et to avoid
conflicts with other, more standard, users of com_err. Also rename the
man page to match

Reviewed-on: http://gerrit.openafs.org/175
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from c321cb467220bbdf2ff49d5fa6e052fd27a4df5e)
Change-Id: I6de96fd2056a632dc8770b5da73604dd20f8c125
Reviewed-on: http://gerrit.openafs.org/992

kernel ioctl32 conversion typecasting

cast types to avoid a pointer from integer warning when using pointer
types for sizing

(cherry picked from 9faaa2fed8c8dd0ae1c9288b1e1130bec78dc9f8)
Change-Id: Idac76608e5352c65a13d07bfadb66d78f9db0ffd
Reviewed-on: http://gerrit.openafs.org/988
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-on: http://gerrit.openafs.org/989

openafs 1.4 butc prototype fallout

minor fallout from pullups of prototyped code.

Change-Id: Ib032794609a5420c402595d15b2d017d401602fa
Reviewed-on: http://gerrit.openafs.org/987
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

Prevent VLRUQ race in ShakeLooseVCaches

When ShakeLooseVCaches is called from afs_Daemon, the xvcache lock
is not held. This means that if the GLOCK is dropped for any reason
(for example, whilst purging the dentry cache), then
ShakeLooseVCaches can be raced, end we can end up attempting to
flush the same vcache twice.

The symptoms of this in Linux are that we oops in clear_inode.

Get the xvcache lock in afs_Daemon(), before calling
ShakeLooseVCaches. Also, remove the conditional GLOCK code from
that function. If we don't have the GLOCK on entry, then we're really
in trouble (and both code paths - afs_Daemon and afs_NewVCache should
get the GLOCK for us, anyway)

FIXES 125589

(cherry picked from 95770bf95ad766207252ea0c2d2b5ab2415c896f)
Change-Id: I3fe5b41a661cd162ec73c51492925ad87c6d4c13
Reviewed-on: http://gerrit.openafs.org/781
Reviewed-by: Marc Dionne <marc.c.dionne@gmail.com>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Reviewed-on: http://gerrit.openafs.org/986

salvager-sensible-chdirlessness-20090122

LICENSE IPL10
FIXES 124154

make salvager look for and create headers in the right place.

Change-Id: Iba6a926818d169e5132a1ffb3b0015f10c8a6ff5
Reviewed-on: http://gerrit.openafs.org/985
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

butc prototype 1.4 fallout

the prototype provided by rxgen breaks this. fix it for now.

Change-Id: I1f1fd663939f67a73d7ca3be85cfbb25b694f1c7
Reviewed-on: http://gerrit.openafs.org/984
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

rx 1.4 mutex naming

in 1.4 rx has just the stats mutex. protect the thread counter with it

Change-Id: Iceec83f23480d3085df711b6fdbcf1171f10bc1a
Reviewed-on: http://gerrit.openafs.org/983
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

packet allocation for 1.4 has no debug counter field

remove the debug counter

Change-Id: If4f615ed572a116b6ba2837d8085d1a8f230dcb6
Reviewed-on: http://gerrit.openafs.org/982
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

Remove hardcoded maximum time

When iterating across the buffer list, afs_newslot used a hardcoded
maximum time to find the oldest. Instead of using this, just use the
accesstime of the first unused buffer that we find as the oldest, and
continue as normal.

Change-Id: Ifeacb8a407901b46a23fbc838b1fca761108ebbb
Reviewed-on: http://gerrit.openafs.org/738
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 293e8c6a1048bf3c342134b5ca6f79d68023258b)
Reviewed-on: http://gerrit.openafs.org/981

Fix locking in afs_buffer.c

Back in 2002, 0eb68f307aac84472a13523a0ce8b7a865f01ac7 was committed
to fix locking problems in dir/buffer.c.

Sadly, similar changes were never made to afs/afs_buffer.c, so the
same problems remain in the cache manager.

The issue here is with two processes racing in afs_newslot. Calls to
afs_newslot protect buffers with a zero reference count using
afs_bufferLock. If we release afs_bufferLock, before we increase the
reference count of the vcache, then we can end up with newslot
picking the same buffer for two different purposes.

The GLOCK actually protects us from the worst of this, but this fix
is necessary both for correctness, and for symmetry with the file
server buffer code.

Change-Id: I7f1c7d6571559c5f1784926c39d4889b77677231
Reviewed-on: http://gerrit.openafs.org/737
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit b21b209f1cb2bafe916543c1ac8f232d6fc84847)
Reviewed-on: http://gerrit.openafs.org/980

OpenAFS Preference Pane
Now the preference pane is fat compiled.

Change-Id: I5c54555d00b16d85f01286719bbc41ea5f1fb67d
Reviewed-on: http://gerrit.openafs.org/906
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 2a69aa22c1278d62008863aabe6833954b4466c0)
Reviewed-on: http://gerrit.openafs.org/979

Correct diskused and files when cloning a volume

Recalculates a volume's disk space used and number of files upon
every clone where it is effortless. Even though tracked mostly
correctly, bugs and accidents leave their traces which only a
salvage would correct.

Change-Id: Ied6fb9eb3944b6e30eac175fe42649c5b7cfaefb
Reviewed-on: http://gerrit.openafs.org/756
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-on: http://gerrit.openafs.org/975

prevent rx peer timeout from reaching 0.0 seconds

The rx peer timeout is computed from the round trip time
calculation. It traditionally has had a lowerbound of 350ms.
The computation in rxi_ComputeRoundTripTime() was incorrect
and instead used 350ms as an upperbound.

rxi_ComputeRoundTripTime() had a second problem wherein if
the actually RTT is shorter than the resolution of the clock
then the RTT would quickly approach 0.0 seconds. Enforce
a lowerbound of 1ms if the RTT for a given packet appears
to be 0.0 seconds.

LICENSE BSD

Change-Id: I83d3a3d64127d4c023df2fce5e45a4df3eb35679
Reviewed-on: http://gerrit.openafs.org/696
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Reviewed-on: http://gerrit.openafs.org/974

Fix a couple more unlink()s in vol-salvage.c

There are a couple more unlink() calls in vol-salvage.c that were using
relative paths. Fix them to use absolute paths and to log a warning if
the unlink() fails.

Reviewed-on: http://gerrit.openafs.org/684
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit ebf6516db2f1105e5ca8172f6d64038c6acc60bd)
Change-Id: Id3a3ee7b6488f54f13f4e9b06996b039eb014e75
Reviewed-on: http://gerrit.openafs.org/973
Tested-by: Derrick Brashear <shadow@dementia.org>

AFSPreference Pane Mounts View refresh issue

Resolved the bug that prevented to show the link description after it was added.
Now the table is refreshed at any operation(add/remove).

Reviewed-on: http://gerrit.openafs.org/682
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit edbef134b7ee2abbd8e2b9639991e5906f3b8fb0)
Change-Id: I4e34a8b14ae47156fa66d49a2e6d4e9c0ed5d1b8
Reviewed-on: http://gerrit.openafs.org/972

Use ranlib -c for Mac OS X Leopard

Building with --enable-demand-attach-fs requires that ranlib -c be
used on Leopard (it is already the default for Tiger)

Reviewed-on: http://gerrit.openafs.org/676
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 7de8be52f5720f865fdfbf59772df1f2ab1bd8e5)
Change-Id: I8c1d47ea326068bceb4831c02225761d400ef1d5
Reviewed-on: http://gerrit.openafs.org/971

OpenAFS Preference Pane 64bit and Symbolic Link features implemented.

Now the OpenAFS preference pane is compiled with 32 and 64 bit snowleopard support, so the preference
windows is no more restarted in 32 bit mode.
The tab for symbolic link creation has been implemented. Now the user can create and delete link.
For create a link both name and destination path must be set. AFSBackgrounder has been updated to
manager in a separate thread the link creation and destroy operation, according to the vaule of
checkbox "Enable Symbolic Link" in "Mounts" tab.

Reviewed-on: http://gerrit.openafs.org/677
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit e82f3b210e0e49fb9d9531565f634ed9d49426a5)
Change-Id: Id974a25df6104de38ff4e9925c1a57b5e0f25112
Reviewed-on: http://gerrit.openafs.org/970

Improve accuracy of Rx RTT calculation by skipping retransmitted packets

Rx RTT calculations are based on Van Jacobson's work using
constants that make computations fast but are not necessarily
the best for modeling Rx protocol exchanges.  This patch does
not alter the constants but does improve the comments to show
that the math is correct.

Phil Karn in 1987 demonstrated that Van Jacobson's algorithms
produced inaccurate results when the RTT computed from an
acknowledgement of a retransmitted packet were included.  The
resulting RTT would either be too small causing the system to
retransmit too many packets or too long resulting in too few
being sent.

This patch follows Phil Karn's advice which was also adopted
as mandatory for TCP in RFC2988.  Retransmitted packets and
delayed acks are skipped and the retransmit time is backed off
(up to a maximum of 3 seconds) until a successful acknowlegement
is received for an initially transmitted packet.

LICENSE BSD

Reviewed-on: http://gerrit.openafs.org/580
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
(cherry picked from commit 917a860e818d5cdda82add0d4d50b594820816f2)
Change-Id: Icae199bfaaa4c64b4ab61eec650ed121c8e36a14
Reviewed-on: http://gerrit.openafs.org/969
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

OSX Launchd Startup Manage with Preference Pane

OpenAFS preference pane has been updated to manage the new launchd startup mode. Has been delete the custom startup and shutdown file now is user the /Library/OpenAFS/Tools/root.client/usr/vice/etc/afs.rc

OpenAFS.postinstall has been modified to remove the old existing /Library/StartupItems/OpenAFS directory
OpenAFS.pre_upgrade has been modified to shutdown daemon, if it is runnig, and remove the old preference pane to permit the one to be installed

Reviewed-on: http://gerrit.openafs.org/578
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit f8cf2a44ab2e896b3c22c9a9e39cc9ade839545e)
Change-Id: I40540cff972606d2fca87ebb601022fd305cf43d
Reviewed-on: http://gerrit.openafs.org/968

OS Preference pane clean for final version

Has been removed from license file the reference to menucracker for hack NSMenuExtra, that is no more needed.

Reviewed-on: http://gerrit.openafs.org/547
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit d9d3902894d1bde920feda7f5f1a798037b52cf8)
Change-Id: Ifd10c1f09373670902a923636dc23b6497fbc98c
Reviewed-on: http://gerrit.openafs.org/967

launchdaemon support for MacOS

the changes needed to switch from a StartupItem to a LaunchDaemon for
the MacOS OpenAFS client

Change-Id: I4c113d232186eaa06bd6793a5fd151053bf91efe
Reviewed-on: http://gerrit.openafs.org/564
Tested-by: Claudio Bisegni <Claudio.Bisegni@lnf.infn.it>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Claudio Bisegni <Claudio.Bisegni@lnf.infn.it>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Reviewed-on: http://gerrit.openafs.org/966

AFSPreference Pane, has changed the content of launchd xml control file for AFSBackgrounder

has been used <key>Program</key> instead of <key>ProgramArgument</key>

Reviewed-on: http://gerrit.openafs.org/495
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit ce9da0d76c53127e7f2f2142832602b52dd78f10)
Change-Id: I354b995e94b923994e4c610d9eade439dcf52bd0
Reviewed-on: http://gerrit.openafs.org/965

Manage the login in the OSX Fast User Switch mode

AFSBackgrounder has been update to get notification for switch in/off in the "Fast User Switch" mode, and in switch in it try to get tokens.

Reviewed-on: http://gerrit.openafs.org/460
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 1ea845ebc953bb49afc354afe036f7f01cd05db8)
Change-Id: I274150b9c048f2e13c62f2fdf148059ffaf35113
Reviewed-on: http://gerrit.openafs.org/964

make fileserver avoid salvage loop on init failure

if the vlserver or prserver setup can't succeed, it doesn't indicate
a condition which salvaging is required to fix; instead, come up
and retry in the background.

Reviewed-on: http://gerrit.openafs.org/428
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 5b6e5019453952f122523354d0001b04189271a7)
Change-Id: I32d918e8153525998d3c6b9401a6e8b4a24b033b
Reviewed-on: http://gerrit.openafs.org/963

Unlink correct files in salvager

Fallout from 0ac956b3384842b3c60e72bde78a4baf58a5877f; a couple of
unlink() calls were not updated to use the absolute path. Update them,
and log errors from unlink(), since otherwise it is difficult to tell
that anything is going wrong.

Reviewed-on: http://gerrit.openafs.org/479
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 29ee678f3ab051a27cae46b02a0d42e0958a6bc8)
Change-Id: Ic7bc1f3470e705f03fee044f438804cdd211db6b
Reviewed-on: http://gerrit.openafs.org/962

make afsd partition size check be large partition safe

right now the math overflows the 32 bit type for >2tb partitions.
use larger variables to avoid this.

Reviewed-on: http://gerrit.openafs.org/392
Reviewed-by: Matt Benjamin <matt@linuxbox.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit ad1e9c7084e99a67ee7a61c255a6059ebc9190c3)
Change-Id: I75c4cd03dadce5218407a5e663474b2cd22a34ad
Reviewed-on: http://gerrit.openafs.org/961

Fix cache tracking for small fragsizes

The tracked amount of disk cache used by a client can be incorrect when
afs_fsfragsize is tuned to below 1023. Since we round up to the next
nearest afs_fsfragsize+1 then round down to the kb, if afs_fsfragsize+1
< 1kb, we can undershoot the cache usage.

This enforces afs_fsfragsize to always be at least 1023.

Change-Id: I2f2f0b14da3f1a57348497f0a372c89388818e9c
Reviewed-on: http://gerrit.openafs.org/338
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Reviewed-on: http://gerrit.openafs.org/960

darwin knet avoid rx socket during shutdown

theoretically a user thread can race us during shutdown and end up
panicing us if the soclose happens at the wrong time. if we're shutting down
just return. using afs_shuttingdown would have the side effect that we'd lose
the ability to add any graceful behavior.

Reviewed-on: http://gerrit.openafs.org/443
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 3898524693e7297e228ded03f34125558f225d58)
Change-Id: I45c3d1a773150ada018a4867139273053f989f57
Reviewed-on: http://gerrit.openafs.org/959

macos package updates

make the readme correct; allow back reving (downgrades)

Reviewed-on: http://gerrit.openafs.org/447
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 4b6fafa440fa51652d12d6522769c8f156b7bda1)
Change-Id: Ia7dd4c505d3674987acbfe2c76c4b4ab02b94fab
Reviewed-on: http://gerrit.openafs.org/958

des crypt cope with 64 bit longs

we test for them in configure; instead of hardcoding it in yet
another place, use the information we have

Reviewed-on: http://gerrit.openafs.org/442
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 98f9b6ae2bafe69440c090443efb2f71ec15309c)
Change-Id: Ied35fdf7c325dbc63bdef1e1ebb328c455bc0133
Reviewed-on: http://gerrit.openafs.org/957

Fixed the tokens update and update .gitignore for MacOSX packaging file

Fixed the tokens update on preference pane if operation is made with NSStatusItem.
Has been updated the src/packaging/MacOS/.gitingore for CellServDB file and src/libafs/.gitignore has been added afs.x86_darwin_100.plist.

Change-Id: Ie91e6e224fcaf9efa840c1153d168139aecb2584
Reviewed-on: http://gerrit.openafs.org/372
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-on: http://gerrit.openafs.org/956

macos afs prefspane support for 10.4

NSUInteger is newer than what's included in the 10.4 SDK. restore
functionality for 10.4

Reviewed-on: http://gerrit.openafs.org/349
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 2b1336b59b554b657a2d671adbc0469e18004fbb)
Change-Id: I087b6dfcca557cd72976ec1f599589c4fabd42d3
Reviewed-on: http://gerrit.openafs.org/955

10.6 update(Workaround for kerberos bug) and cleaning of deprecated function form code

For aklog has been added the workaround for kerberos function KLAcquireInitialTickets that in 10.6 return always error.
First is called KLCacheHasValidTickets for check user ticket presence, if there are no ticket KLAcquireNewInitialTickets will be called for get user credential.
Has been removed also many deprecated api.

Reviewed-on: http://gerrit.openafs.org/341
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit b695261de43af0fbdd8166b4b2272465783e76d6)
Change-Id: I77e29b1f8668f346cc4ec6ef48f447aae8d68dfa
Reviewed-on: http://gerrit.openafs.org/954

Make MacOS installer pane permit dashes

The MacOS installer only permits characters in [0-9A-Za-z] in cellnames.
However, OpenAFS itself will also allow dashes, and they're in use by some
sites.

This trivially amends the installer pane to permit dashes.

FIXES 125211

Reviewed-on: http://gerrit.openafs.org/323
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 57e218ab61e824133f252e4a0da74552beb14b05)
Change-Id: I0b37eb4a3f0aeb530d91341896c797dbf2aaeb2d
Reviewed-on: http://gerrit.openafs.org/953

OSX Preference Pane and AFS Backgrounder

Cleaned most unused log

Reviewed-on: http://gerrit.openafs.org/308
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit ff138d1bdeab24de27790474adf24ea124a211f1)
Change-Id: Ia42110dadfa87e9f2bc129c5b32ead0184b8d27a
Reviewed-on: http://gerrit.openafs.org/952

OSX AFSBackgrounder fix minor bug

Has been fixed the status menu icon width, now i keeped from icon image.
Fixed the status item icon view redraw.

Reviewed-on: http://gerrit.openafs.org/305
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit ce174b9ef1771395981b297d4bb8779e57c9afab)
Change-Id: I2c907a898a4c1a47e73c35da4fed385956f1536d
Reviewed-on: http://gerrit.openafs.org/951

Removed user perspectivev3 file in xcode project and update the gitconfig

gitconfig in src/platform/DARWIN/AFSPreference has been modified to ignore the perspectivev3 that is created by xcode for window layout.Has been also delete the file created for the user

Reviewed-on: http://gerrit.openafs.org/267
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 20243612a15b150a3dbb3c9e027c1c79a0e5f200)
Change-Id: Ia662362eaa7a14c56bd558e9d03b98eaa1934f50
Reviewed-on: http://gerrit.openafs.org/950

Cleaned most warning OSX OpenAFS preference and completed the AFSBackgrounder implementation

At startup the preference pane check for the presence in ~/Library/LaunchAgents of the file it.infn.lnf.network.AFSBackgrounder.plist that. The agent could be started in OpenAFS preference pane view.
AFSBackgrounder has replaced the NSMenuExtra, when it doesn't quit well launchd restart it. AFSBackgrounder can be used also for other work, for now, at login it check the user preference for get token.
Has been made some refactoring in code for remove most warning.
The unused think are been delete from project.

Reviewed-on: http://gerrit.openafs.org/263
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit b0818fcdb227c8b291eb7b23e504fd1d2240eea6)
Change-Id: I155643e479de6e8fcb3bf286c16e339cb1fdb2f3
Reviewed-on: http://gerrit.openafs.org/949

AFS Backgrounder implementation & warirng clean

Replaced the NSMenuExtra and created the AFSBackgrounder that will do all work for aklog at login and manage the Status menu in menu bar

Reviewed-on: http://gerrit.openafs.org/262
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 7868e1961048d2a24bd5d4d5afab07d3dbf54fd2)
Change-Id: I379d1091dd8b376d5036e447651465ee9b099863
Reviewed-on: http://gerrit.openafs.org/948

Start coding OSX Backgrounder Application, for OpenAFS Preference Pane, that user NSStatusItem

To prevent future compatibility with osx we must use NSStatusItem instead NSMenuExtra that is not documented api.
For this has been created a background only application that will manage all function managed by current NSMenuExtra

Reviewed-on: http://gerrit.openafs.org/261
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit f52f509962fbaade008f5dc6c2f8a3bece70c13c)
Change-Id: I69815922f40ea51c380c7300648e9dfa3bb809b5
Reviewed-on: http://gerrit.openafs.org/947

install AFSCommander in prefpane dir

make the AFSCommander prefPane be installed, in /Library (as
are growl, macfuse, etc)

Reviewed-on: http://gerrit.openafs.org/243
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 6640b8b064b238333a46ef72aa09913b06271a91)
Change-Id: Ic9e46c62ee3587012bed33c737573cfc18b4672d
Reviewed-on: http://gerrit.openafs.org/946

In rxi_SendPacket[List], down hosts if ENETUNREACH or equivalent

This patch causes rxi_SendPacket[List] to "down" a host if
rxi_Sendmsg() returns -ENETUNREACH (or equivalent). Previous behavior
only did this check if defined(KERNEL) becauase non-defined(KERNEL)
implementations did not return meaningful error codes from
rxi_Sendmsg().

Jeff Altman <jaltman@openafs.org> supplied the logic for the
AFS_NT40_ENV case; I was not able to test this (I do not own a
Windows license) and took him on his word.

Reviewed-on: http://gerrit.openafs.org/59
Reviewed-by: Adam Megacz <megacz@gmail.com>
Tested-by: Adam Megacz <megacz@gmail.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 1ddc7fa920213f9b5455e632bbddf05b866af647)
Change-Id: I1c5bdf8f3216f82f32fcf22f1c47a3a43130e071
Reviewed-on: http://gerrit.openafs.org/945

Build fix - pre-processor typos in rx_lwp.c and rx_pthread.c

Commit 119c756d96c4a7f9e01e4ff6bb20156f1abf761b introduced a typo
in two places, using #elif instead of the apparently intended #else.

Reviewed-on: http://gerrit.openafs.org/231
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
(cherry picked from commit 9a490c96a074f4c3c82a3f01c18bc74cc19ae184)
Change-Id: Ic6282bb1535c0d4ba206736d1c2ae5c088bf2a7e
Reviewed-on: http://gerrit.openafs.org/944
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

Use -errno or WSAGetLastError() as return value from rxi_Sendmsg()

This patch causes the pthread and lwp implementations of rxi_Sendmsg()
to use -errno or WSAGetLastError() as the return value if it is
positive. This is required in order to communicate more meaningful
error conditions to rxi_SendPacket[List], which should "down" a host
immediately when it observes ENETUNREACH.

Jeff Altman <jaltman@openafs.org> supplied the logic for the
AFS_NT40_ENV case; I was not able to test this (I do not own a
Windows license) and took him on his word.

Reviewed-on: http://gerrit.openafs.org/58
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Adam Megacz <megacz@gmail.com>
Tested-by: Adam Megacz <megacz@gmail.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 119c756d96c4a7f9e01e4ff6bb20156f1abf761b)
Change-Id: I31f97e4cef4b32abb69c783d19b1adfd897889fa
Reviewed-on: http://gerrit.openafs.org/943

Running bos -noauth should not require client CellServDB configuration

When setting up a new cell, the admin is instructed to use "bos -noauth"
to configure the servers and only afterwards create the client configuration.
This leads to a catch-22 since currently bos -noauth fails if there is no
client configuration even though it is not required.

This change avoids the call to afsconf_Open() which is only required
if tokens are being acquired.

FIXES 125156

Reviewed-on: http://gerrit.openafs.org/209
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
(cherry picked from commit e435e248f44c46866cb73db185b9548c0bd148b4)
Change-Id: I5a40091410bcc4b28fce04b7cd65ae797b3d8ed0
Reviewed-on: http://gerrit.openafs.org/942
Tested-by: Derrick Brashear <shadow@dementia.org>

afsprefs pane shouldn't hardcode 10.4 sdk

10.4 sdk isn't available in the release after 10.5 as a default. don't hardcode it
same with afscell

Reviewed-on: http://gerrit.openafs.org/207
Tested-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit a6025e0268fd7cff6ee7de145bdbf59cc350c572)
Change-Id: I404861b1d27c9ff8eef4c61707f14d4c36b7ea9d
Reviewed-on: http://gerrit.openafs.org/941

Finish afscell implementation work

This patch completes the implementation of an install time prompeter
for information about the local AFS cell, which is then used to populate
the ThisCell file. It removes the need for manual editing of
configuration files as part of the installation.

(Build system modified by Simon Wilkinson from Toby's original patch)

Change-Id: I6f4e2232d8d6270f6d29994d24bf9b4e3f0eb1a3
Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/201
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Reviewed-on: http://gerrit.openafs.org/940

platform makefile should handle clean target

pass "make clean" through to platform-specific makefiles

Change-Id: If8c78c76b9c2cd573c84809c6a0ffe17327694d9
Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/198
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Reviewed-on: http://gerrit.openafs.org/939

Makefile.in modification for compile AFSPreference source code

Have been added the rule "OpenAFS.prefPane" tha compile with xcodebuild the xcode project

Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/197
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit f1bb016e12a1f4bb3b9b01d5a9abe4f8c8dabe32)
Change-Id: If747e6cafce06fba7a338059636763a521279ae5
Reviewed-on: http://gerrit.openafs.org/938

OSX Preference Pane Source Import

Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/196
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 694c5ca3f400ce88219f60edec75249bf73cc8fc)
Change-Id: I4078bfc6004431c2dd277cbc2a665b4c6cc412a3
Reviewed-on: http://gerrit.openafs.org/937

OSX Preference Pane

Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/195
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 2675642e024f56a3069414d1f96ee440c9cb0c77)
Change-Id: I8f1c1fe751962efc0180a2eb6063eb83becb1e2a
Reviewed-on: http://gerrit.openafs.org/936

avoid call to rxi_FreePacket with NULL pointer

the function rx_ReadProc32 (src/rx/rx_rdwr.c) checks the pointer
call->currentPacket before the function rxi_FreePacket is called. This
test was missing in the function rx_ReadProc.

FIXES 125110

Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/178
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
(cherry picked from commit e35dfdcce9d11607669783844331ad2dbafd2793)
Change-Id: I1156403dc3d7e64d4176577e51933b79b00442db
Reviewed-on: http://gerrit.openafs.org/935
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

AFSOP_STOP_RXEVENT sometimes set without wakeup

make sure when AFSOP_STOP_RXEVENT is set, a wakeup is sent on the
variable so waiters realize it's the case

Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/162
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Tested-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Reviewed-by: Russ Allbery <rra@stanford.edu>
(cherry picked from commit ba27f1b3cb08db66e184682b30d60ff6fc4ce43e)
Change-Id: If2ac96e7c793c8d4c93492625f006abefac634d1
Reviewed-on: http://gerrit.openafs.org/934
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

vos print_addr() must call ubik_VL_GetAddrsU with correct level of indirection

Reported by Marcus Watts.

print_addr() accepts a afsUUID* and must not pass the address of
that variable to ubik_VL_GetAddrsU.

LICENSE IPL10

Reviewed-on: http://gerrit.openafs.org/101
Verified-by: Russ Allbery <rra@stanford.edu>
Reviewed-by: Russ Allbery <rra@stanford.edu>
(cherry picked from commit 86b0f09bddeded9515f39ad17b47a0b4e23a968b)
Change-Id: I07050a8025eae384194615e78d97641d144ce8b2
Reviewed-on: http://gerrit.openafs.org/933
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

Make 'fs listquota' output readable for large quota

With the old print format quota and used values became one large
number for quotas in the terabyte range.

Fix alignment of the "no limit" string in the Windows fs command
for volumes with no quota.

Reviewed-on: http://gerrit.openafs.org/34
Verified-by: Russ Allbery <rra@stanford.edu>
Reviewed-by: Russ Allbery <rra@stanford.edu>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
(cherry picked from commit 42d64b5b1f9944fe35bd6358ebeba9a24162243e)
Change-Id: I2dbb186a91df96ec1b0693e8ccd3bda01ac28a48
Reviewed-on: http://gerrit.openafs.org/932
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

Fix assert message to avoid printing garbage

Fix an off by one error in assert() to avoid printing garbage
characters to the log. Remove the newline character generated by
ctime() to match the format generated by the other logging functions.

FIXES 124613

Reviewed-on: http://gerrit.openafs.org/102
Verified-by: Russ Allbery <rra@stanford.edu>
Reviewed-by: Russ Allbery <rra@stanford.edu>
(cherry picked from commit 15d203c7be957ba0e63288e2d95cbd078d94eb21)
Change-Id: I4720285db68f30730f67d62978d777fd6857fc7a
Reviewed-on: http://gerrit.openafs.org/931
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

Correct pointer type of 'next' field within struct volinfo

Reported by Marcus Watts

The next field of struct volinfo is supposed to be a pointer
to a struct volinfo.

LICENSE IPL10

Reviewed-on: http://gerrit.openafs.org/87
Verified-by: Russ Allbery <rra@stanford.edu>
Reviewed-by: Russ Allbery <rra@stanford.edu>
(cherry picked from commit 47e31b020c3393fdbda9dddd99269482693cfb6c)
Change-Id: I719f6417abc68d5ab2595241b247eeb83cf7affc
Reviewed-on: http://gerrit.openafs.org/930
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

linux-locking-brace-fix-20090602

LICENSE IPL10

so regardless of which code branch we choose we work
(cherry picked from commit 521f4e6d473335ac8f7f265904bda7840fddad71)

Change-Id: I5ec0ff52ac769a35548b5a583bff4a9b849ab609
Reviewed-on: http://gerrit.openafs.org/929
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

linux-byte-range-locks-sensibility-20090526

LICENSE IPL10
FIXES 124766

make our locks work correctly with the linux connectathon lock testing

Change-Id: Ic632c30f597881ae40a8b412a3a1fd99f35ef025
Reviewed-on: http://gerrit.openafs.org/928
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

rx-pthread-mutex-protects-threadcount-20090128

LICENSE BSD

add protection of previously unprotected thread count variables
(cherry picked from commit 226cf894b65c62225785180dfeeed0ec1c1a160b)

Change-Id: Id0e6172ff64175323c7867c0156fabca753d7e97
Reviewed-on: http://gerrit.openafs.org/927
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

fix-tsfpq-20090210

LICENSE BSD

avoid transferring more than the number of packets in a queue

Change-Id: I1c2ae660bdaa117aa16f91ca24ce08326bf436a4
Reviewed-on: http://gerrit.openafs.org/926
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

tsm41-makefile-fix-20090609

LICENSE IPL10

fix form of case statement in makefile for tsm41
(cherry picked from commit a8614747878cedef5e54f10dcc7296034a88e738)

Change-Id: I673e66b9a3e957c20f0d84fe31bee11f26d3e341
Reviewed-on: http://gerrit.openafs.org/925
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

Search for the Linux version in the correct header

src/config/linux-version already had support for handling either versioned
or unversioned kernel source directories, but the grep for UTS_RELEASE
was unconditionally done against the versioned source tree, ignoring the
previous determination of where the header file was.

Instead, check instead the header file location that we'd previously
determined.

This patch has been tested in the Debian OpenAFS 1.4.11~pre3+dfsg-1
package.

Reviewed-on: http://gerrit.openafs.org/4
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Verified-by: Russ Allbery <rra@stanford.edu>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit ecd3fc42d1d6dca23bb2e2728a0066d3db8eceb6)
Change-Id: I286109d139320f7ce71c5d5265bc3e4a2fca4945
Reviewed-on: http://gerrit.openafs.org/924
Tested-by: Derrick Brashear <shadow@dementia.org>

rx-user-socket-buffer-sizes-20090110

LICENSE MIT

if the socket buffer size specified by the configuration is too large
to be applied, do not drop down immediately to 32766 bytes. Instead
try increasingly smaller values trying to find the largest one that
works. use the same value for the send buf size as well.
(cherry picked from commit 5b0e23567e1ed64f448bb3253ad90d39cad31271)

Change-Id: I7cb1ded895458d099be5aeffc712a914193e18c0
Reviewed-on: http://gerrit.openafs.org/922
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

salvager-no-chdir-20081108

LICENSE IPL10
FIXES 123577

make sure salvager cores don't get left in vice partitions
(cherry picked from commit 0ac956b3384842b3c60e72bde78a4baf58a5877f)

Change-Id: I12f34ef66d7783d5615959553749b7a2ec4f2692
Reviewed-on: http://gerrit.openafs.org/921
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

asm unexecutable stack

make stack not executable in assembled files

FIXES 125491

Change-Id: I396680b6877843201f6c07d5607385044abd5e74
Reviewed-on: http://gerrit.openafs.org/818
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Reviewed-by: Russ Allbery <rra@stanford.edu>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 9bfd03d723a9cf17673f40513a7adde1d503bcbc)
Reviewed-on: http://gerrit.openafs.org/976

rx-rdwr-avoid-free-null-packet-20081026

LICENSE MIT

avoid a potential call to rxi_FreePacket with a NULL pointer as input

Change-Id: Id18712f44779dd4e26215049e74d55a0d68d1409
Reviewed-on: http://gerrit.openafs.org/920
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

rx-change-packet-allocation-calculation-20080925

LICENSE IPL10

don't alloc ourselves to death; try harder to manage growth

Change-Id: Idee89b272c46b9d183cc44f6588b3906a0b7aa07
Reviewed-on: http://gerrit.openafs.org/919
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

rx-buffer-allocation-corrected-20080813

LICENSE MIT

a corrected version of delta rx-buffer-allocation-20080812
(cherry picked from commit 919fb5e14bdcde66218e64cfdd7fecccab67d8f5)

Change-Id: Idd029c06f4a625b03aef6db56ffd7c006fc36f77
Reviewed-on: http://gerrit.openafs.org/918
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

Move afscell to platform/DARWIN

Move our current afscell code into platform/DARWIN so that it's in a
location that can be added to the build, rather than packaging, step

Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/200
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit b4564fa8254afbfef94915f1051a5ad7ab17b11d)
Change-Id: I2a13a556730cf2bd205a66609bc9cb34b12dcd47
Reviewed-on: http://gerrit.openafs.org/917

macos-afscell-configurator-20080423

LICENSE IPL10

not ready for release, but, add a tool which installer can run to ask for a cell
name
AUTHOR
LICENSE IPL10

====================
This delta was composed from multiple commits as part of the CVS->Git migration.
The checkin message with each commit was inconsistent.
The following are the additional commit messages.
====================
LICENSE IPL10

not ready for release, but, add a tool which installer can run to ask for a cell
name
(cherry picked from commit b1bf96f7581e58137f49e2b685cf6e91ff4f7dda)

Change-Id: I13ca9268e679e029f97260712f1ac7331fd90b2d
Reviewed-on: http://gerrit.openafs.org/916
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

Move end label into correct position

The end label was in the wrong #ifdef block in order to actually be referenced
in the case where USEIFADDR is unset

Reviewed-on: http://gerrit.openafs.org/226
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
(cherry picked from commit 4c2e426d2dad559e1ed2c2c43d48193400b22c61)
Change-Id: If7a3ed246da58aca60b60dcf5501430acc999b0c
Reviewed-on: http://gerrit.openafs.org/915
Tested-by: Derrick Brashear <shadow@dementia.org>

viced: set volume sync data in bulk status rpcs

The bulkstatus and inlinebulkstatus rpcs have a bug
that prevents the volume sync data from being set.
Currently the data is being set within the for loop
only when i == nfiles. The conditional of the loop
is i < nfiles so the SetVolumeSync call is never
performed. This patch changes the test for performing
SetVolumeSync to i == 0.

LICENSE MIT

Change-Id: I17e3980184ec68e38c5186e1c9637ac6e38451fe
Reviewed-on: http://gerrit.openafs.org/856
Reviewed-by: Dan Hyde <drh@umich.edu>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 13843d852749ba081804f3af368620db7b4b7d7a)
Reviewed-on: http://gerrit.openafs.org/914

macos avoid dotunderbar lookups in fakestat mode

cocoa tries to lookup ._ files for every object, possibly generating
AFSDB queries and other fun. avoid them

Change-Id: Id70b6335d4dddcb6d5628a9883b2c81193bb39d7
Reviewed-on: http://gerrit.openafs.org/896
Reviewed-by: Rod Widdowson <rdw@steadingsoftware.com>
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 019ae5240691f27beaf583084fc81f4efb84b166)
Reviewed-on: http://gerrit.openafs.org/913

vos-move-avoid-spurious-unlock-20080424

LICENSE IPL10

lightly modified from what Bren Mills submitted; the second unlock call after mfail may be entirely useless.
(cherry picked from commit b87935a4c5f26357e29f1db46eff8b1cf9185f3b)

Change-Id: I82478dabe1df66fc261e8d7c64bb898b3a60d88b
Reviewed-on: http://gerrit.openafs.org/912
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

Linux: Fix lock ordering

The inode mutex (or semaphore) should be held before acquiring the
alloc semaphore. Fix the lock ordering to avoid theoretical deadlocks.

Change-Id: Ifc572083dc92fff51be6785b0bcc92152fab1d73
Reviewed-on: http://gerrit.openafs.org/835
Reviewed-by: Marc Dionne <marc.c.dionne@gmail.com>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit a2744cab12c87a8c42ba40a9f186a1f05c6886f8)
Reviewed-on: http://gerrit.openafs.org/977

macos panic decoder should handle 64 bit kernel in 32 bit mode

panic from 64 bit should be decodable in 32 bit mode. make it so. add
-k switch to allow a path to a kernel to be specified.

Reviewed-on: http://gerrit.openafs.org/438
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 754a4b628a14657db2e00931926311a1c703558b)
Change-Id: I6611c2dddca7138d4136f6409b82f3200755f099
Reviewed-on: http://gerrit.openafs.org/910