If the realm name of the requested ticket is the empty string, decode
the actual service ticket to determine the actual realm. Obtaining the
actual realm prevents unnecessary pts registration failures.
make the aklog lam plugin work correctly in e.g. the CDE screenlocker, which is
part of the long-running and not-run-by-user dtsession; this means we do wackiness to
1) not pag ourselves in that case
2) setuid to the user to set uid tokens if we got a username and are root
3) do not use pr_mumble get the the AFS ID to put in the tokens, as multiple
initializations of Rx in the process space of dtsession crashes it
Do not trust the registry to determine whether or not krb4 support
is available. In a roaming profile the user data can say 'yes' even
if the plug-in or the kerberos library does not exist.
avoid a race condition between cm_SyncOpCheckContinue and cm_SyncOpDone
that can leave a request on an scp stuck in the waiting state even though
there are no other requests to wake it up.
cm_BkgPrefetch() contained two errors. First, the loop at the top of the
function that ensures that a cm_buf_t is allocated for each of the offset
positions failed to actually obtain the buffer for the specified offset.
Instead, it repeatedly obtained the buffer for the starting base address.
Second, cm_GetBuffer() would reserve all of the buffers associated with
the cm_scache_t even in the case where we already have a callback and the
existing buffer has the proper data version number. In that situation
reserving the buffers simply wastes valuable time.
1. avoid re-reading CellServDB each time a cell alias is specified
2. avoid reconstructing the vlserver list for the cell each time an
alias is specified
3. permit aliases to be used when AFSDB records were used previously
with the full cell name
Reduce the default number of background daemon threads used for prefetch and
store operations to one. Given the current implementation when more than
one thread is allocated they step on each other's toe while fighting over
locks.
A better model might be to divide up threads based upon cells or volumes
as a means of preventing contention.
The case of openafs.org and grand.central.org is a hideous abuse of
the AFS cell name space. There are many negatives associated with
trying to support two different cell names pointing at overlapping
vlserver lists:
(1) The CM can store duplicate entries for all of the data simply because
the cell name that was used is different
(2) If the CM attempts to optimize the data storage by aliasing or otherwise
combining the cell names as part of one cm_cell_t object, then future
attempts to separate the two cell names will require the destruction
of the cache.
(3) If the CM does not associate a callback revoke with a particular cell,
then the status data associated with any entry that matches the revoked
AFSFid will be discarded. For volume callbacks this can have a serious
impact because volume IDs are not unique across cells and discarding
status data for readonly volumes that are in use can result in a
significant number of FetchStatus requests being sent to the associated
file server.
There are other issues as well involving authentication.
The case of openafs.org advertising the vlserver addresses of
grand.central.org should be considered a hack; a hack that the Windows
client will no longer ensure will work.
Additional debugging messages have been added to assist individuals attempting
to debug why callback revokes do not appear to take affect when two cell
names share the same vlserver data.
The pthread_cond_timedwait/wait implementations were broken. Not only
did they return the wrong error values but more importantly, they did not
always return with the mutex locked.
Update event_handler() for Windows. The return code of
pthread_cond_timedwait() is not limited to 0 and -1 because 'errno'
cannot be set. Instead of setting 'errno' the error code is returned
directly by the function as the return code.
This patch is only for debugging purposes to track the number of
success, timeout, and other errors experienced by the routine.
Add some additional cross-references, add some missing man pages, fix a
few references to the OpenAFS manuals, document the -live flag to vos
move, and add an example for rxdebug.
Remove the callback revoke optimization that prevents a (vol,vn,uniq)
tupple from invalidating entries from multiple cells. We cannot reliably
determine the cell from the server because the server might be identified
as belonging to more than one cell. For example, openafs.org and
grand.central.org.
Windows Error Reporting received crashes caused by a failure to synchronize
the shutdown of the AFS client service with the background daemon threads.
The daemon threads (cm_Daemon, cm_BkgDaemon+, cm_IPAddrDaemon) could be
accessing data structures as they were being freed or unmapped.
Add synchronization mechanisms to signal the termination of the threads
with the shutdown of the service.
This patch completes the implementation of smb_ReceiveTran2GetDFSReferral()
which is called by Vista even if we do not advertise the support of DFS
referrals. It also adds DFS link mapping notifications to the volstat
interface which can be used by volstat plug-ins to redirect requests to
the dfs target path.
Other miscellaneous items:
(1) return EAS_NOT_SUPPORTED instead of EA length 0 and silently accepting
but not storing EA data
(2) Call cm_VolStatus_Service_Started() before smb initialization instead
of afterwards
(3) During directory enumeration and link assembly push the UNC path into
the lower levels by storing references to the tidPath and the relative
paths within the cm_req_t object.
(4) During directory enumeration make absolutely sure that we do not
reference an unallocated cm_dirEntry_t object
(5) publish a prototype for cm_FollowMountPoint()
(6) return ERROR_RETRY instead of BAD_NETWORK_PATH if the server returns
VBUSY
(7) return PATH_NOT_COVERED instead of BADSHARENAME for DfsLinks when
a volstat plugin is in use
In the error case (1) reference the mountPointString instead of the
output of cm_AssembleLink() which was not generated and (2) do not
free memory and objects that were not allocated nor reference counted.
remove panic due to lock being grabbedin another thread can't be accurately
covered with this test on darwin, as e.g. proc_selfthread() is not in the KPI
When a cm_MergeStatus operation determines that the current data buffers
are out of date, remove them from the buffer hash tables in order to speed
the lookup of valid data buffers.
after removing cm_buf_t objects from the hash tables, clear the HT list
pointers to make debugging easier.
when modifying data version values in buf_ForceDataVersion() grab a
read lock on buf_globalLock instead of a write lock. A write lock is
only required if the hash table linked lists are being modified.
The dataVersion itself is protected by the cm_scache_t mx mutex being
held.
Windows requires open() to be called with O_BINARY otherwise Ctrl-Z
means EOF which breaks dumpfile processing.
Be consistent about writing/reading time as afs_uint32 instead of
writing as afs_uint32 and reading as time_t since time_t can be 32-bit
or 64-bit depending on the platform.
Add a registry value, GiveUpAllCallBacks, that can be used to enable/disable
the use of the GiveUpAllCallBacks RPC. Due to the fact that calling this RPC
can destablize pre-1.4.6 file servers since they do not include DELTA
giveupallcallbacks-locking-20071121, the default is being set to disabled.
We can re-enable the functionality by default only after sufficient time
has been given for orgs to update their file servers.
It turns out that LsaCallAuthenticationPackage can succeed but still
fail with an extended error. The one case that we have seen reported
is STATUS_NO_MEMORY which would be produced when the paging file is
full. This could be a transient error that will be resolved after
Windows increases the paging file size.
Instead of crashing under this condition we should force the authentication
to fail and permit the client to retry.
The cm_Daemon() thread did not check after each operation whether or
not the service is in the process of shutting down. As a result the
thread could access data, locks, etc. that had been freed by other
threads.
====================
This delta was composed from multiple commits as part of the CVS->Git migration.
The checkin message with each commit was inconsistent.
The following are the additional commit messages.
====================
projects / packages / o / openafs.git / log