]> git.michaelhowe.org Git - packages/o/openafs.git/log
packages/o/openafs.git
15 years agoFinalize changes for 1.4.12.1+dfsg-1 debian/1.4.12.1+dfsg-1
Russ Allbery [Wed, 26 May 2010 15:58:58 +0000 (08:58 -0700)]
Finalize changes for 1.4.12.1+dfsg-1

15 years agoprdb_verify -rebuild with supergroups fix
Jason Rogers [Mon, 15 Feb 2010 23:19:12 +0000 (17:19 -0600)]
prdb_verify -rebuild with supergroups fix

This change eliminates the redundant iteration over the
supergroup[] array in DumpRecreate. By iterating over both
this array and entries[], duplicate au lines are created
and the count variable becomes incorrect. Furthermore,
the au lines created in the supergroups[] section were
incorrectly in the form of au <group> <member> instead
of au <member> <group>.

FIXES 126500

Change-Id: I087772b63934406273f153f4b8a581d965f1e4d5
Reviewed-on: http://gerrit.openafs.org/1316
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Tested-by: Michael Meffie <mmeffie@sinenomine.net>
Reviewed-by: Alistair Ferguson <alistair.ferguson@mac.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit fa2536c02cf26f7db30bf623e95f42be88138d14)
(cherry picked from commit dfa356732fd10073c3b777ccf48f753fcd528c93)
Reviewed-on: http://gerrit.openafs.org/1945
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 3fc5c5311fc4bfe5586818fa26bdccd846d4c8cc)

15 years agoviced-host-uuid-and-addr-hashing-corrections-20090530
Dan Hyde [Mon, 26 Apr 2010 20:08:40 +0000 (16:08 -0400)]
viced-host-uuid-and-addr-hashing-corrections-20090530

LICENSE IPL10
FIXES 124634

only valid addr/port pairs are registered in the hash table.
add then remove when changing addresses.
make host restoral properly hash hosts.
remove should remove the address we asked for and not simply the
primary address.

Change-Id: I765a81f5e993bbc0b275ea93cd84cc67e67b14ff

(cherry picked from commit ca613599a2537756462a420ae1a632747a433226)

Change-Id: I765a81f5e993bbc0b275ea93cd84cc67e67b14ff
Reviewed-on: http://gerrit.openafs.org/1843
Tested-by: Dan Hyde <drh@umich.edu>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit c29ac4fe358eabac40d30cbe5519d6c10073ba53)

15 years agoAdd changelog entries for cherry-picked upstream fixes
Russ Allbery [Wed, 26 May 2010 15:23:49 +0000 (08:23 -0700)]
Add changelog entries for cherry-picked upstream fixes

15 years agoMerge commit 'upstream/1.4.12.1+dfsg'
Russ Allbery [Wed, 26 May 2010 15:13:16 +0000 (08:13 -0700)]
Merge commit 'upstream/1.4.12.1+dfsg'

15 years agoImported upstream tag openafs-stable-1_4_12_1 via tarball upstream/1.4.12.1+dfsg
Russ Allbery [Wed, 26 May 2010 15:12:22 +0000 (08:12 -0700)]
Imported upstream tag openafs-stable-1_4_12_1 via tarball

15 years agoAdjust get-orig-source for location of patch releases
Russ Allbery [Wed, 26 May 2010 15:11:07 +0000 (08:11 -0700)]
Adjust get-orig-source for location of patch releases

* Adjust get-orig-source to cope with tarballs for patch releases being
  in the same directory as the parent normal release.

15 years agoAdd initial changelog for 1.4.12.1+dfsg-1
Russ Allbery [Wed, 26 May 2010 15:06:52 +0000 (08:06 -0700)]
Add initial changelog for 1.4.12.1+dfsg-1

15 years agomake openafs 1.4.12.1 openafs-stable-1_4_12_1
Derrick Brashear [Mon, 24 May 2010 18:45:16 +0000 (14:45 -0400)]
make openafs 1.4.12.1

update configure scripts with new version number

Change-Id: I3d75cdd481369aaaaaa3de343c70360a6e20847a

15 years agoMove non-executable stack assembly code to end of file
Russ Allbery [Mon, 22 Mar 2010 19:42:48 +0000 (12:42 -0700)]
Move non-executable stack assembly code to end of file

The non-executable stack annotation used for Linux works by adding
an additional section to the generated object.  The annotation added
in 9bfd03d723a9cf17673f40513a7adde1d503bcbc was added to the beginning
of each assembly file.  This caused build failures on Linux s390
because the remainder of the assembly code was then put in that
section, which was discarded during linking.

Add the annotation to the end of each assembly file instead, following
the instructions at:

    http://www.gentoo.org/proj/en/hardened/gnu-stack.xml

Change-Id: I5bd2d8d0ac31932b59757dcec0a942c459d61cac
Reviewed-on: http://gerrit.openafs.org/1615
Tested-by: Russ Allbery <rra@stanford.edu>
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 9dbe48ac2d14742d2acefb9cb4138b810a1a128e)

15 years agofix other oldtvix typo
Derrick Brashear [Mon, 26 Apr 2010 04:21:30 +0000 (00:21 -0400)]
fix other oldtvix typo

i failed to push this to commit 0dac8f93af5262472bc5bdf94dbb605a24da59d0,
and so, well, here's the real fix. sorry.

Change-Id: I6799ecb207f246ac3e4c48b1de55268d2fba4d23
Reviewed-on: http://gerrit.openafs.org/1837
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry-picked from commit 51c1eb362da866e28a9fb9a6f5d9d412aac7e8c2)

Change-Id: If42f31b47d50aecb147fa82040a6c3ab48f7a7ce
Reviewed-on: http://gerrit.openafs.org/2009
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
15 years agoInitialize oldvtix
Marc Dionne [Thu, 22 Apr 2010 21:22:37 +0000 (17:22 -0400)]
Initialize oldvtix

Initialize the variable to avoid compiler complaints that it
could be used uninitialized.  Use a sentinel value and issue
a warning if we try to use the variable and we haven't set
it to a useful value.

Change-Id: I037be2ad8e0b55d06b50aafdeca5012764640f16
Reviewed-on: http://gerrit.openafs.org/1810
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry-picked from commit 0dac8f93af5262472bc5bdf94dbb605a24da59d0)

Change-Id: I3311ad5a73e21f7fb44f9dcf0cda251bae96eb0f
Reviewed-on: http://gerrit.openafs.org/2008
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
15 years agoRecover from afs_GetVolSlot errors
Andrew Deason [Wed, 21 Apr 2010 17:41:21 +0000 (12:41 -0500)]
Recover from afs_GetVolSlot errors

afs_GetVolSlot can panic in a few different ways, such as failing to
read from or write to VolumeInfo. Instead of panic'ing, return an
error to the application. Adjust callers to deal with getting a NULL
volume returned.

Based on a patch by Mike Meffie.

Change-Id: Ibb301fed795ee9ee5906b8e7973945a06218b8f1
Reviewed-on: http://gerrit.openafs.org/1801
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry-picked from commit 80f05473428969ff71d1791cda8cb09d30223724)

Change-Id: Ie89034cb0fcc8f92868f338996d62edfe150b1b2
Reviewed-on: http://gerrit.openafs.org/2004
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
15 years agoLinux: replace invalidate_inode_pages
Marc Dionne [Fri, 5 Mar 2010 22:54:42 +0000 (17:54 -0500)]
Linux: replace invalidate_inode_pages

This helper has been deprecated for a while, and gets removed
with 2.6.34.
Replace it with invalidate_remote_inode, which has been around for
all of 2.6's life, according to Chaskiel in RT #124377.

Change-Id: I8658b454e1c997c041f654ba55d06f713ea25459
Reviewed-on: http://gerrit.openafs.org/1523
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 80481fb14ea9301b0f6b3503d07ecaef39aef0d8)
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Reviewed-on: http://gerrit.openafs.org/1988

15 years agomacos 32 bit platform user address transform
Derrick Brashear [Fri, 2 Apr 2010 05:29:22 +0000 (01:29 -0400)]
macos 32 bit platform user address transform

make the ioctl32 translator work as expected, e.g., create
proper user addresses.

Change-Id: Ia690dee5f9978d679e942a9954f2123df4a96bc2
Reviewed-on: http://gerrit.openafs.org/1687
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit ec74299c7c0f6e705e6ba2329001b92f9941868e)

15 years agoCheck if AFS is mounted before killing processes with open files debian/1.4.12+dfsg-5
Russ Allbery [Tue, 4 May 2010 23:26:15 +0000 (16:26 -0700)]
Check if AFS is mounted before killing processes with open files

* Skip killing processes with files open in AFS if AFS does not appear
  to be mounted according to /etc/mtab.  Otherwise, we may call lsof
  without a specific mount point and kill far more processes than we
  intend to.  (This code is disabled by default, so this problem would
  only be seen by people who enabled it.)

15 years agoFinalize changes for 1.4.12+dfsg-4 debian/1.4.12+dfsg-4
Russ Allbery [Tue, 4 May 2010 22:38:01 +0000 (15:38 -0700)]
Finalize changes for 1.4.12+dfsg-4

15 years agoParse /etc/mtab instead of the mount command to find the AFS mount
Russ Allbery [Tue, 4 May 2010 22:25:09 +0000 (15:25 -0700)]
Parse /etc/mtab instead of the mount command to find the AFS mount

The /etc/mtab syntax doesn't contain an English word and is therefore
less likely to change based on localization.  Hopefully this will be
equivalent.

15 years agoIn the openafs-client init script, don't assume AFS is mounted at /afs
Russ Allbery [Tue, 4 May 2010 22:06:52 +0000 (15:06 -0700)]
In the openafs-client init script, don't assume AFS is mounted at /afs

* In the openafs-client init script, don't assume that AFS is mounted on
  /afs when unmounting it or killing processes with AFS files open.
  Instead, parse the output from mount to find the AFS mount point.

15 years agoRead all members of previous cacheinfo file
Russ Allbery [Tue, 4 May 2010 21:51:37 +0000 (14:51 -0700)]
Read all members of previous cacheinfo file

If we don't have three destination variables, the cachedir gets the
cache size appended to it.  Add a cachesize variable whose contents
we then ignore.

15 years agoLinux Keyrings: don't ignore error code from session keyring creation
Marc Dionne [Sat, 23 Jan 2010 01:03:58 +0000 (20:03 -0500)]
Linux Keyrings: don't ignore error code from session keyring creation

Creating a session keyring can fail, for instance if the user's
keyring quotas are reached (number of keys/keyrings or data size).

Instead of ignoring errors, return them so they can be passed back
to the caller.

FIXES 126230

Reviewed-on: http://gerrit.openafs.org/1151
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from 0caf14224a9153bb488be9e52d67892a2c441a5a)

Change-Id: Ibffa5ff33f756c9365b1148448039e668d39fb92
Reviewed-on: http://gerrit.openafs.org/1581
Reviewed-by: Alistair Ferguson <alistair.ferguson@mac.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 0bec77e1f9dfdb7927926953b808603647910cc0)

15 years agoAdjust afs_lockctl to compensate for byte-range lock fixes
Anders Kaseorg [Sun, 21 Feb 2010 01:52:06 +0000 (20:52 -0500)]
Adjust afs_lockctl to compensate for byte-range lock fixes

As of commit 49b7bbdd3b45df694fadbef48f9ed99d9bfe07b9, l_len is no
longer 1 less than it should be.  Update afs_lockctl to expect this.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Change-Id: I3fb7665457d489e56564b14933795084a0958d6f
Reviewed-on: http://gerrit.openafs.org/1353
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 99e704c791bbedd9aa3fc1a0feb9493b0eaefd7d)
Reviewed-on: http://gerrit.openafs.org/1373
(cherry picked from commit 89193695da6dc8946e4a03ed40081a91050ca5dc)

15 years agoVOL_LOCK needed when traversing DiskPartitionList
Dan Hyde [Tue, 2 Feb 2010 15:37:47 +0000 (10:37 -0500)]
VOL_LOCK needed when traversing DiskPartitionList

VLockPartition sets VOL_LOCK, opens (perhaps creating) the lock file
for a partition, and flock's it.  VUnlockPartition, sets VOL_LOCK, and
closes the lock file fd.

VLockPartition is called from the salvager.  Nothing ever calls
VUnlockPartition.

VPFullUnlock is called every 30 seconds, does NOT set VOL_LOCK, and
happily closes any lock file fd it finds, breaking any lock set with
flock.

Other routines use the VOL_LOCK when traversing DiskPartitionList.

Change-Id: I28aa02488a6b53dc9f9aa9b2053c71d29222bdaf
Reviewed-on: http://gerrit.openafs.org/1213
Reviewed-by: Dan Hyde <drh@umich.edu>
Tested-by: Dan Hyde <drh@umich.edu>
(cherry picked from commit 105481d3348a93d33695fb705f9fa5c8af210e7e)
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-on: http://gerrit.openafs.org/1595
(cherry picked from commit 3c1d60a19ccdc23ecd9eb0ca79bd72816abcd82e)

15 years agoLinux: don't count pag keys against root's keyring quotas
Marc Dionne [Wed, 27 Jan 2010 00:48:24 +0000 (19:48 -0500)]
Linux: don't count pag keys against root's keyring quotas

Keys associated with PAGs are created with root ownership for
security reasons, which means that they count agains root's
keyring quotas.  The default configuration used by most distros
restricts root to the same quotas as a regular user, so a single
user can potentially fill up the quota and prevent new pags from
getting created system-wide.

This can also be an issue for busy multi-user systems where the
default maximum number of keys (200 currently) can easily be reached.

Reviewed-on: http://gerrit.openafs.org/1167
Reviewed-by: Marc Dionne <marc.c.dionne@gmail.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit a3812f211a56c0d6e0a7ff8a97f157707d3d8c28)

Change-Id: I5c12e55d98d5f887c60a7ae1cf1aa64f37282ce3
Reviewed-on: http://gerrit.openafs.org/1580
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit a27015099a1dc1e41001e4a4946848f958c6a09b)

15 years agoAdd changelog for upstream cherry-picks
Russ Allbery [Tue, 4 May 2010 21:32:21 +0000 (14:32 -0700)]
Add changelog for upstream cherry-picks

15 years agoPreserve AFS mount point and cache directory in cacheinfo
Russ Allbery [Tue, 4 May 2010 21:27:36 +0000 (14:27 -0700)]
Preserve AFS mount point and cache directory in cacheinfo

* Preserve the AFS mount point and cache directorys set in
  /etc/openafs/cacheinfo if the file already exists rather than
  overwriting them with the defaults.  Thanks, Liam Healy.
  (Closes: #580077)

15 years agoFinalize changes for 1.4.12+dfsg-3 debian/1.4.12+dfsg-3
Russ Allbery [Fri, 26 Mar 2010 23:05:38 +0000 (16:05 -0700)]
Finalize changes for 1.4.12+dfsg-3

15 years agoAdd changelog entry for upstream cherry-picks
Russ Allbery [Fri, 26 Mar 2010 19:28:35 +0000 (12:28 -0700)]
Add changelog entry for upstream cherry-picks

15 years agoPrint rxdebug statistics as unsigned values
Marc Dionne [Wed, 24 Mar 2010 23:29:28 +0000 (19:29 -0400)]
Print rxdebug statistics as unsigned values

bytesSent and bytesReceived are unsigned.  Print them as such
to avoid printing negative numbers for large values.  This is
already the case in the master branch.

Bug reported by jakllsch on IRC

Change-Id: If2c5d9cfebf11691d73b3d6bfd73deb6b61ada8e
Reviewed-on: http://gerrit.openafs.org/1657
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit a123d4ab988c6a8cc51b864ea1d02a70b2770bf3)

15 years agoIncrease the maximum number of sysnames
Evan Broder [Wed, 4 Nov 2009 04:50:39 +0000 (23:50 -0500)]
Increase the maximum number of sysnames

Change-Id: I8438ca19649730260370d8b00fb0157e808abe31
Reviewed-on: http://gerrit.openafs.org/778
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit b772bd7e3c1305710eb3c18b2fe4108e467bd383)
Reviewed-on: http://gerrit.openafs.org/1650
(cherry picked from commit 812dcc2c1b4e0f333dd0a85f46066c8018aad79b)

15 years agovolmonitor keep vtrans lock
Dan Hyde [Wed, 13 Jan 2010 19:38:47 +0000 (14:38 -0500)]
volmonitor keep vtrans lock

VolMonitor must maintain the VTRANS lock the whole time it is walking
the allTrans list.  Failure to do so can cause core dumps trying to
access memory that has already been free'd.

Two versions of this change were coded and tested.  The other version
used the VTRANS lock only around a THOLD, but needed a TRELE, too.
Timing tests were run counting the number of vos status, vos listvol,
and vos backupsys operations that could be performed during a fixed
number of vos status operations.  The THOLD/TRELE version caused other
vos operations to run about 5% slower.

FIXES 126110

Change-Id: I7e749d30c955867faacafa978d7d643dee648ca3
Reviewed-on: http://gerrit.openafs.org/1098
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit d4f6ece19b05f2233e53f2d3c59f92316ec5ec3a)
Change-Id: Ic12bb6687a9c34e85abc2023c02264de6ae27614
Reviewed-on: http://gerrit.openafs.org/1588
Reviewed-by: Dan Hyde <drh@umich.edu>
Tested-by: Dan Hyde <drh@umich.edu>
(cherry picked from commit 190ef2cb29577f2fcf1853149cf210fdf0736ae3)

15 years agoCreate missing root directory when ORPH_ATTACH
Andrew Deason [Wed, 3 Feb 2010 19:02:23 +0000 (13:02 -0600)]
Create missing root directory when ORPH_ATTACH

When we are salvaging with ORPH_ATTACH, orphans are normally attached to
a volume's root directory. If the volume is missing a root directory,
however, nothing is attached, and the volume can appear empty or
unusable.

So, to make it possible to get a useful volume out of a volume that lost
(only) its root directory, create a new root dir, and attach orphans to
that root.

FIXES 94658

Reviewed-on: http://gerrit.openafs.org/1235
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 32ebc44f42aad7dd77d42d07bfd891e8be6f1fff)

Change-Id: Ib74507e28630ce409f412b67f19d6008d215c6b0
Reviewed-on: http://gerrit.openafs.org/1613
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 135e196b6145d5d2ebddc1d65b3193d2b5c7cffb)

15 years agoDon't add CellServDB records if AFSDB is in use
Russ Allbery [Fri, 26 Mar 2010 19:25:01 +0000 (12:25 -0700)]
Don't add CellServDB records if AFSDB is in use

* If the user configures openafs-client to use AFSDB records for VLDB
  server location, don't prompt the user for VLDB servers for the local
  cell even if they're not present in CellServDB and don't try to add an
  entry for the local cell to CellServDB.  (Closes: #575299)

15 years agoFinalize changes for 1.4.12+dfsg-2 debian/1.4.12+dfsg-2
Russ Allbery [Mon, 22 Mar 2010 22:53:56 +0000 (15:53 -0700)]
Finalize changes for 1.4.12+dfsg-2

15 years agoBuild with -fno-strict-aliasing
Russ Allbery [Mon, 22 Mar 2010 22:41:38 +0000 (15:41 -0700)]
Build with -fno-strict-aliasing

* Build with -fno-strict-aliasing.  The upstream development branch has
  a better fix that selectively enables this for specific files with
  known problems, but be conservative for the stable release.

15 years agoMove non-executable stack assembly code to end of file
Russ Allbery [Mon, 22 Mar 2010 19:42:48 +0000 (12:42 -0700)]
Move non-executable stack assembly code to end of file

The non-executable stack annotation used for Linux works by adding
an additional section to the generated object.  The annotation added
in 9bfd03d723a9cf17673f40513a7adde1d503bcbc was added to the beginning
of each assembly file.  This caused build failures on Linux s390
because the remainder of the assembly code was then put in that
section, which was discarded during linking.

Add the annotation to the end of each assembly file instead, following
the instructions at:

    http://www.gentoo.org/proj/en/hardened/gnu-stack.xml

Change-Id: I5bd2d8d0ac31932b59757dcec0a942c459d61cac
Reviewed-on: http://gerrit.openafs.org/1615
Tested-by: Russ Allbery <rra@stanford.edu>
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 9dbe48ac2d14742d2acefb9cb4138b810a1a128e)
Reviewed-on: http://gerrit.openafs.org/1618
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit eb799d07e7dd37f379a4e84df5eb3397b16f5a41)

15 years agovolmonitor copy link before calling free
Dan Hyde [Wed, 6 Jan 2010 15:49:39 +0000 (10:49 -0500)]
volmonitor copy link before calling free

Copy tt->next before TRELE(tt) calls free(tt).

We have a core file from a VTRANS_OBJ_LOCK(tt) assert failure, with tt
pointing into glibc's malloc data structures.
(cherry picked from commit 81ca1e19600681a2c5696610130b9a39809bb1c1)

Change-Id: I5ba81f9e3a76f52578ab3b9dec394b6d95b03934
Reviewed-on: http://gerrit.openafs.org/1586
Reviewed-by: Dan Hyde <drh@umich.edu>
Tested-by: Dan Hyde <drh@umich.edu>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 0583af324ca2cbc556722b9e84d85cad49cfc622)

15 years agoh_TossStuff_r: make sure host does not go away
Andrew Deason [Tue, 16 Feb 2010 17:08:38 +0000 (11:08 -0600)]
h_TossStuff_r: make sure host does not go away

When h_TossStuff_r h_NBLock_r's a host, it is not only possible for
someone else to grab a hold on the host, but in theory it's also
possible for someone to hold a host, release it, and for the host to be
deleted again (assuming some callers hold HOSTDELETED hosts, which they
should not be doing).

To make this safety check a bit more robust, hold the host in
h_TossStuff_r before h_NBLock_r'ing, to ensure that it does not go away
while we're waiting for H_LOCK.

Reviewed-on: http://gerrit.openafs.org/1330
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 380bd77c328d8d83a007cd97f6564fcb5b990a73)

Change-Id: I19d001dba8b0c96b694aefdba2475f0103d33e44
Reviewed-on: http://gerrit.openafs.org/1368
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit b78eeb0cca48c65d4466052d207fa22f08a8fa70)

15 years agoh_TossStuff_r: check held-ness after lock
Andrew Deason [Mon, 15 Feb 2010 16:55:33 +0000 (10:55 -0600)]
h_TossStuff_r: check held-ness after lock

h_TossStuff_r checks if a host is held or locked by another thread
before trying to delete the host. Unfortunately, it checks if it is
locked before checking if it is held, and the lock check drops H_LOCK.
Thus, another thread could hold the host while we don't have H_LOCK, and
we could delete a host that is being held.

Although it is a bug if any thread holds a host that is being deleted,
some instances of this still exist, so make the check more robust.
Reverse the order of the tests, so we detect if someone held the host
while the lock check dropped H_LOCK.

Also log when this happens, as it indicates a bug occurring.

FIXES 126454

Reviewed-on: http://gerrit.openafs.org/1312
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Alistair Ferguson <alistair.ferguson@mac.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 45aceee9842265fb0ccdb5e8f3f6d32c8d2b99ea)

Change-Id: Ibce716b0d57d02d1ad912276dfa9f4b169294947
Reviewed-on: http://gerrit.openafs.org/1367
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 94a439668b8ef90027f922e9fb85fe1f3e983100)

15 years agoAllow GetSomeSpace_r to select an optimal host
Andrew Deason [Mon, 15 Feb 2010 22:22:56 +0000 (16:22 -0600)]
Allow GetSomeSpace_r to select an optimal host

Previously GetSomeSpace_r would never find an 'ideal' host for which to
clear callbacks, since lih0_r and lih1_r required a non-NULL rock to do
anything. Remove the requirement for the passed-in host rock to be
non-NULL, and make lih*_r more threadsafe, by passing in a parameter
struct for the rock.

Also attempt to make the GSS_r code a bit more clear with some
descriptive variable names and such.

FIXES 126451

Reviewed-on: http://gerrit.openafs.org/1317
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit eb7d90fd0db68ea49ec1820adda599b5922c7de2)

Change-Id: I1c283153977f47cb21c57bf6e65305068c6fd3be
Reviewed-on: http://gerrit.openafs.org/1370
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit f3899ac3b342ad065dd9484720a4d721a3fb549a)

15 years agoAdd changelog entries for upstream cherry-picks
Russ Allbery [Mon, 22 Mar 2010 22:38:39 +0000 (15:38 -0700)]
Add changelog entries for upstream cherry-picks

15 years agoRemove lih_r
Andrew Deason [Mon, 22 Feb 2010 21:58:57 +0000 (15:58 -0600)]
Remove lih_r

Nothing references the function lih_r anymore. Remove the dead code, and
be a little more similar to what's on master.

Change-Id: I00262cd27156fc370cd74c35d2e7a0309e1037f9
Reviewed-on: http://gerrit.openafs.org/1369
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Alistair Ferguson <alistair.ferguson@mac.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 4ca7b6fcc124f473ed5b86bea804a9df5d2c8833)

15 years agoHopefully finalize changes for 1.4.12+dfsg-1 debian/1.4.12+dfsg-1
Russ Allbery [Tue, 9 Mar 2010 00:32:53 +0000 (16:32 -0800)]
Hopefully finalize changes for 1.4.12+dfsg-1

15 years agoMerge branch 'upstream'
Russ Allbery [Tue, 9 Mar 2010 00:30:41 +0000 (16:30 -0800)]
Merge branch 'upstream'

15 years agoImported upstream tag openafs-stable-1_4_12 via tarball upstream/1.4.12+dfsg
Russ Allbery [Tue, 9 Mar 2010 00:30:11 +0000 (16:30 -0800)]
Imported upstream tag openafs-stable-1_4_12 via tarball

15 years agoNote which remote to fetch in README.source
Russ Allbery [Tue, 9 Mar 2010 00:29:12 +0000 (16:29 -0800)]
Note which remote to fetch in README.source

15 years agoUpdate changelog for the final 1.4.12 release
Russ Allbery [Tue, 9 Mar 2010 00:24:46 +0000 (16:24 -0800)]
Update changelog for the final 1.4.12 release

Switch the get-orig-source target back to the main release directory.

15 years agoRequire $remote_fs before stopping as well
Russ Allbery [Mon, 8 Mar 2010 23:45:17 +0000 (15:45 -0800)]
Require $remote_fs before stopping as well

This isn't strictly necessary, but it avoids the Lintian warning and we
can clean it up after finding a better approach for what /usr/bin/fs
currently does.

15 years agoUpdate standards version to 3.8.4
Russ Allbery [Mon, 8 Mar 2010 23:08:16 +0000 (15:08 -0800)]
Update standards version to 3.8.4

15 years agoUpdate CellServDB to the 2010-02-28 version
Russ Allbery [Mon, 8 Mar 2010 23:07:03 +0000 (15:07 -0800)]
Update CellServDB to the 2010-02-28 version

15 years agoUse dh_dkms for DKMS maintainer script handling
Russ Allbery [Mon, 8 Mar 2010 23:05:37 +0000 (15:05 -0800)]
Use dh_dkms for DKMS maintainer script handling

* Use dh_dkms from the DKMS package to handle creation of the maintainer
  scripts for openafs-modules-dkms rather than rolling our own.
  (LP: #497149)

15 years agoMerge commit 'upstream/1.4.12.pre4+dfsg'
Russ Allbery [Mon, 8 Mar 2010 22:52:43 +0000 (14:52 -0800)]
Merge commit 'upstream/1.4.12.pre4+dfsg'

Conflicts:
configure.in
src/afs/LINUX/osi_file.c
src/cf/linux-test3.m4
src/cf/linux-test4.m4
src/viced/host.c

15 years agoImported upstream tag openafs-stable-1_4_12pre4 via tarball upstream/1.4.12.pre4+dfsg
Russ Allbery [Mon, 8 Mar 2010 22:49:59 +0000 (14:49 -0800)]
Imported upstream tag openafs-stable-1_4_12pre4 via tarball

15 years agoInitial changelog for 1.4.12~pre4
Russ Allbery [Mon, 8 Mar 2010 22:18:05 +0000 (14:18 -0800)]
Initial changelog for 1.4.12~pre4

Add upstream change list since the deltas that I pulled up.  Switch
the download area over to the candidate releases.  (1.4.12 will
probably be released before this package is uploaded, but we'll pull
1.4.12~pre4 first to get the packaging updated.)

15 years agoremove fc_test from normal build openafs-stable-1_4_12
Derrick Brashear [Mon, 8 Mar 2010 17:27:28 +0000 (12:27 -0500)]
remove fc_test from normal build

1.5 deals with this differently. for now, don't build fc_test (rx needs
libsys so it can deal with network config from userspace; the sys/rxkad
dependancies are circular if so. so, no)

Change-Id: I4936fd610d9346aa78665664e76a2023783d6654
Reviewed-on: http://gerrit.openafs.org/1536
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
15 years agoopenafs 1.4.12
Derrick Brashear [Mon, 8 Mar 2010 16:46:41 +0000 (11:46 -0500)]
openafs 1.4.12

make 1.4.12 changes for versioning

Change-Id: I528ab7b9f6de85eed4e3fb053e7dc7cc7d0986fc
Reviewed-on: http://gerrit.openafs.org/1535
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
15 years agoBegin support for OpenBSD 4.7
Antoine Verheijen [Wed, 3 Mar 2010 18:57:29 +0000 (11:57 -0700)]
Begin support for OpenBSD 4.7

Add config param header and sysname number for OpenBSD 4.7 (currently
in beta).

Change-Id: I6537bd352becd9a8c3937e95f79911c8bc08bcfb
Reviewed-on: http://gerrit.openafs.org/1533
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 7aca59c2f6c8097fbc0cafab18fe4cdfe28e89c2)
Change-Id: I8cc317cf6cf64e72323da0efcb402a43802df9a8
Reviewed-on: http://gerrit.openafs.org/1510

15 years agoOpenBSD: eliminate use of VREF() macro
Antoine Verheijen [Sun, 7 Mar 2010 19:50:06 +0000 (14:50 -0500)]
OpenBSD: eliminate use of VREF() macro

OpenBSD 4.7 (currently in beta) removes the (dummy) VREF() macro from the
system header files. For at least as far back as OpenBSD 3.6, all this
macro does is expand to a call to a system routine by the same name in
lower case. This patch therefore replaces the single OpenBSD use of
VREF() with a direct call to the routine to which it expanded.

Change-Id: I44888ed1ba7ba8e7150202798def10bed2ab3158
Reviewed-on: http://gerrit.openafs.org/1532
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit a31bbd3123dd7bd5c0f73c1bcd89548d489930a8)
Change-Id: I442d5e9cfa9bd7f5886692c0afcbb3d220d0ca5b
Reviewed-on: http://gerrit.openafs.org/1509

15 years agodarwin afshelper fix startup check
Derrick Brashear [Thu, 4 Mar 2010 19:16:04 +0000 (14:16 -0500)]
darwin afshelper fix startup check

make the launchd check run as root without whining about passwords
repeatedly

Change-Id: Ib4bac7c9ddf1837a8e86bf17a8a66b6ba1247272
Reviewed-on: http://gerrit.openafs.org/1511
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 08aec0182a888f38fa50ca4e1dbd9ed83e022a2a)
Reviewed-on: http://gerrit.openafs.org/1516

15 years agocorrect cred mgmt typo
Derrick Brashear [Fri, 5 Mar 2010 01:27:15 +0000 (20:27 -0500)]
correct cred mgmt typo

crfree is not crfee

Change-Id: I28de28f8b93220a694272898ef02185e749e8d49
Reviewed-on: http://gerrit.openafs.org/1515
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
15 years agoremove the force.. comments
Derrick Brashear [Wed, 3 Mar 2010 16:25:18 +0000 (11:25 -0500)]
remove the force.. comments

we're not c++; don't use c++ comments.

Change-Id: I4bb68c61bacefe41c6fd367fd6f0dadb0bc64886
Reviewed-on: http://gerrit.openafs.org/1508
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
15 years agoLinux: bdi doesn't always have a name
Simon Wilkinson [Thu, 18 Feb 2010 23:09:40 +0000 (23:09 +0000)]
Linux: bdi doesn't always have a name

The 'name' element of the backing_dev_info structure is new in
2.6.32 - add yet another configure test, and #ifdef to protect our
setting of it.

Change-Id: I0a3e411e571e05771619381bf621d299482c695b
Reviewed-on: http://gerrit.openafs.org/1341
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit a9951410e1cb1a713f9d26a24d6b3cf485f94ac6)
Reviewed-on: http://gerrit.openafs.org/1498
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
15 years agolinux bdi allocate memory
Derrick Brashear [Tue, 16 Feb 2010 18:10:09 +0000 (13:10 -0500)]
linux bdi allocate memory

allocate bdi with osi_Alloc (and free with osi_Free)
seems to fix an oops

FIXES 126514

Change-Id: I667391710c5fd2b6712117471247f1cd7c20aa9b
Reviewed-on: http://gerrit.openafs.org/1332
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 8f1e1199a2ef65ac0c5f00dcb30aeb8114c95551)
Reviewed-on: http://gerrit.openafs.org/1497

15 years agoOSXPreferencePane
Claudio Bisegni [Mon, 1 Mar 2010 19:41:48 +0000 (20:41 +0100)]
OSXPreferencePane
checkAfsStatusForStartup method modification for search /afs volume for determinate if afs is on has been transfered into checkAfsStatus. checkAfsStatusForStartup method is used to check when afs start axitn system startup. Anyway these are only workaround we must use osx api or afs api to make this job.

Change-Id: If9be5a91418eccc0c58a69b566af140d619d3057
Reviewed-on: http://gerrit.openafs.org/1492
Reviewed-by: Claudio Bisegni <Claudio.Bisegni@lnf.infn.it>
Tested-by: Claudio Bisegni <Claudio.Bisegni@lnf.infn.it>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit b7b51cb22c56cb7304a9d6c9c9b12eaaa470db49)
Reviewed-on: http://gerrit.openafs.org/1494

15 years agomacos prefs pane more reliable running indicator
Derrick Brashear [Sun, 28 Feb 2010 01:09:42 +0000 (20:09 -0500)]
macos prefs pane more reliable running indicator

instead of grepping ps output, look for AFS in df output. not
happy with this either but it's way more reliable.

Change-Id: I73ff53bc1cc24c9484011a870546b6334ff66b49
Reviewed-on: http://gerrit.openafs.org/1410
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit f0ce809181d19e865817200dab4fb8370bceeb59)
Reviewed-on: http://gerrit.openafs.org/1493

15 years agomacos prefs pane krb5 auth setup
Derrick Brashear [Sat, 27 Feb 2010 22:48:19 +0000 (17:48 -0500)]
macos prefs pane krb5 auth setup

when we configure krb5-at-login, don't inadvertantly reorder the list.
replace inline.

FIXES 126628

Change-Id: I23de38dadeae6a01d6f97d84e7bb6d9e75e99510
Reviewed-on: http://gerrit.openafs.org/1408
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-on: http://gerrit.openafs.org/1409

15 years agoadd libsys.a to rxkad Makefile
Chaz Chandler [Thu, 25 Feb 2010 22:54:18 +0000 (17:54 -0500)]
add libsys.a to rxkad Makefile

IRIX needs libsys for afs_syscall, added to fc_test_LIBS to avoid
compilation error

Change-Id: Ic6db560c5a03af871663216a47e3898b94e776f3
Reviewed-on: http://gerrit.openafs.org/1400
Reviewed-by: Chaz Chandler
Tested-by: Chaz Chandler
Reviewed-by: Derrick Brashear <shadow@dementia.org>
15 years agoFix (p)install of compile_et (addendum)
Antoine Verheijen [Thu, 25 Feb 2010 08:54:30 +0000 (01:54 -0700)]
Fix (p)install of compile_et (addendum)

A prior update (ChangeID: Ie6af2d3fd9c5166dd2d884c22d287c180b24fab1)
stops compile_et from being (p)installed into a separate directory.
Unfortunately, there's a second rule in the Makefile exhibiting the
same behaviour that was missed (the decision of which rule is used is
determined by whether a 'make install' or 'make dest' is requested).
This patch fixes the second ruleset as well.

Change-Id: I0e94d5cf0bb4e46a24fba6e77aa6baff2118f78b
Reviewed-on: http://gerrit.openafs.org/1397
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
15 years agomake openafs 1.4.12pre4 openafs-stable-1_4_12pre4
Derrick Brashear [Thu, 25 Feb 2010 04:42:07 +0000 (23:42 -0500)]
make openafs 1.4.12pre4

make version strings for 1.4.12pre4

Change-Id: Ie81809c622ed0b59d67b3e58e07b60b4f5a41ff4
Reviewed-on: http://gerrit.openafs.org/1394
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
15 years agoremove dropbox attribute leak fix
Derrick Brashear [Wed, 24 Feb 2010 16:20:51 +0000 (11:20 -0500)]
remove dropbox attribute leak fix

change 6ec18461649d3e4f44b2476f886bcc480c456500, avoid leaking stat info,
appears to have side effects on at least macos, crashing the system
coreservicesd. revoke the change until the exact behavior we want is
better understood.

(cherry picked from commit 142883cae8de203822c8be4f975e691b57be2834)

Change-Id: Id3a03e7b3982abb3947c9b3d1baa46c828169cdb
Reviewed-on: http://gerrit.openafs.org/1389
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
15 years agoLinux: Fix conversion of whole-file locks
Anders Kaseorg [Sun, 21 Feb 2010 01:28:42 +0000 (20:28 -0500)]
Linux: Fix conversion of whole-file locks

An overflow bug in commit 49b7bbdd3b45df694fadbef48f9ed99d9bfe07b9
caused whole-file locks to be treated as byte-range locks, which fail
to be propagated to other machines.

Fix this by setting l_len = 0 for locks that range to the end of the
file.

FIXES 126561

Change-Id: Ie2dc9d04f33559c73b3b86b64152c549b785f8ad
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Reviewed-on: http://gerrit.openafs.org/1352
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit d3abbebcb0651c5d2c7a3094270fd4f86bea3c1e)
Reviewed-on: http://gerrit.openafs.org/1372

15 years agoLinux: autoconf.h is moving in 2.6.33
Anders Kaseorg [Sat, 20 Feb 2010 18:36:22 +0000 (13:36 -0500)]
Linux: autoconf.h is moving in 2.6.33

In 2.6.33, <linux/autoconf.h> is moving to <generated/autoconf.h>.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Change-Id: Ib97031728b89cf8e17581f3c425216ae4b5538ec
Reviewed-on: http://gerrit.openafs.org/1351
Reviewed-by: Marc Dionne <marc.c.dionne@gmail.com>
Tested-by: Marc Dionne <marc.c.dionne@gmail.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 91e50aa81bdeecbdf351088b3b5510fe3c8e848e)
Reviewed-on: http://gerrit.openafs.org/1375
Tested-by: Derrick Brashear <shadow@dementia.org>
15 years agoLinux: Use kbuild to check for UML
Anders Kaseorg [Sat, 20 Feb 2010 18:28:59 +0000 (13:28 -0500)]
Linux: Use kbuild to check for UML

<linux/autoconf.h> is automatically included by kbuild; you aren’t
supposed to include it directly.  That breaks in 2.6.33 because
<linux/autoconf.h> is moving to <generated/autoconf.h>.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Change-Id: I56c90dfe90ef72408620793fcd4e927ea3d8f468
Reviewed-on: http://gerrit.openafs.org/1350
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 660c7a3952f36fc892e12aa6b11eda3295b1416d)
Reviewed-on: http://gerrit.openafs.org/1374

15 years agoCheck for HOSTDELETED before h_Hold_r
Andrew Deason [Fri, 12 Feb 2010 23:44:31 +0000 (17:44 -0600)]
Check for HOSTDELETED before h_Hold_r

A few places h_Hold_r a host and later drop and reacquire H_LOCK without
checking if the hostFlags contains HOSTDELETED. This can cause a race
with h_TossStuff_r where we later reference a host that is about to be
freed or already has been freed.

Add checks for HOSTDELETED in these places, and skip over the deleted
hosts.

FIXES 126454

Reviewed-on: http://gerrit.openafs.org/1305
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit b8c3c6add90ea3face9a16ff04a1024be3d8f32d)

Change-Id: I9e67465b3dac6db8626fee03823ed63a680beaad
Reviewed-on: http://gerrit.openafs.org/1366
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
15 years agoCorrect the h_Enumerate_r hostList safety check
Andrew Deason [Fri, 12 Feb 2010 22:30:44 +0000 (16:30 -0600)]
Correct the h_Enumerate_r hostList safety check

Ide1e5aca7c2c4a4af3f62bc07821db694f2f9999 added safety checks for a few
traversals through hostList, including the traversal in h_Enumerate_r.
Unfortunately, h_Enumerate_r may not hold H_LOCK over its entire
traversal (h_Release_r can drop and reacquire it), so the value of
hostCount is not guaranteed to stay the same.

A host may be deleted during the loop, or right near the end, decreasing
hostCount to below our current running 'count' of hosts, triggering the
panic unnecessarily. So instead, remember the value of hostCount.

Reviewed-on: http://gerrit.openafs.org/1304
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 4dfbbd34ce66c09593a0b1a88831ec0f36848fe8)

Change-Id: I8e39d3bbe16e96a1d3f56e3b19d5f30c3810f6bc
Reviewed-on: http://gerrit.openafs.org/1365
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
15 years agoanalyze warning fix
Derrick Brashear [Mon, 22 Feb 2010 18:58:58 +0000 (13:58 -0500)]
analyze warning fix

initialize variable. warnings caught this in the other compiler

Change-Id: Iae2ae5c1aefe29603bbf5d9952f65b0119f4db9b
Reviewed-on: http://gerrit.openafs.org/1363
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 1e731a22ae954900af036d1ade014a07418ae4ea)
Reviewed-on: http://gerrit.openafs.org/1364

15 years agoanalyze paranoia
Derrick Brashear [Mon, 22 Feb 2010 17:15:15 +0000 (12:15 -0500)]
analyze paranoia

don't pass a null pointer to FindVolume in case one shows up

Change-Id: I76258d8f8ca18c536e3faa776df3e06005fe2bc2
Reviewed-on: http://gerrit.openafs.org/1360
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 48908e2a932420fe67fe1065d55f7e458b5cd1c2)
Reviewed-on: http://gerrit.openafs.org/1361

15 years agoidledead client dont interrupt writes
Derrick Brashear [Sun, 21 Feb 2010 22:15:26 +0000 (17:15 -0500)]
idledead client dont interrupt writes

allowing failover is nonsensical, there's nothing to fail to. keep trying to
write. if we want to change this, we need to handle it better than just this.

Change-Id: Ibed4c63182f44ed9e659895e4868b4192d004688
Reviewed-on: http://gerrit.openafs.org/1355
Tested-by: Stephan Wiesand <stephan.wiesand@desy.de>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 01f42cad663cc860e451f694f973ca46f03289ff)
Reviewed-on: http://gerrit.openafs.org/1359

15 years agoLinux: Remove unused LINUX_KERNEL_SELINUX test
Anders Kaseorg [Sat, 20 Feb 2010 19:47:45 +0000 (14:47 -0500)]
Linux: Remove unused LINUX_KERNEL_SELINUX test

This test needs <linux/autoconf.h>, which has moved in 2.6.33.  It is
also unused (it was removed in master by commit
35d5b6c4e101c92e2c242bb75029db24eb1aa7d7).

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Change-Id: I7876fed2ed2b0395cdf29c71edfdad1089c88cce
Reviewed-on: http://gerrit.openafs.org/1354
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
15 years agomake openafs 1.4.12pre3 openafs-stable-1_4_12pre3
Derrick Brashear [Thu, 11 Feb 2010 05:18:47 +0000 (00:18 -0500)]
make openafs 1.4.12pre3

make version strings for 1.4.12pre3

Change-Id: I6873dc6717176318fabc3344cddb804bb1b4a499
Reviewed-on: http://gerrit.openafs.org/1293
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
15 years agoLinux: Use current_creds() if stashed creds fail
Simon Wilkinson [Tue, 9 Feb 2010 19:53:40 +0000 (19:53 +0000)]
Linux: Use current_creds() if stashed creds fail

If we can't use our stashed credentials (because SELinux hates us,
most likely), then fall back to trying the processes current credentials
instead of just oopsing.

Change-Id: Ib3676ff66f8400e86cccb97fb207a5f094ceb4ad
Reviewed-on: http://gerrit.openafs.org/1283
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Marc Dionne <marc.c.dionne@gmail.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit bcdb5220e2db2bf0cd22c6316682046425048d87)
Reviewed-on: http://gerrit.openafs.org/1289

15 years agoafs_TruncateAllSegments() make sure correct afs_size_t comparison is
Rainer Toebbicke [Mon, 8 Feb 2010 14:18:04 +0000 (15:18 +0100)]
afs_TruncateAllSegments() make sure correct afs_size_t comparison is
used when selecting dcache entries for truncation

Insure that afs_TruncateAllSegments() uses the correct [64-bit]
comparison when deciding whether to truncate chunks:
alen - AFS_CHUNKTOBASE(tdc->f.chunk) for a file > 2GB would fail
to be recognised negative with an "afs_int32 newSize", even with
alen = 0 and big tdc->f.chunk.

Change-Id: Id77109fb8238234dae725bd876f70ea0fbd403fc
Change-Id: If0120e21a52316e536d03241c83e8f0d36614c13
Reviewed-on: http://gerrit.openafs.org/1252
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 3913aa55eed10f9d6316910ef950f5c3242e20d7)
Reviewed-on: http://gerrit.openafs.org/1282

15 years agoOpenBSD: don't use AFS_GLOBAL_SUNLOCK on single processor system
Antoine Verheijen [Mon, 8 Feb 2010 21:57:51 +0000 (14:57 -0700)]
OpenBSD: don't use AFS_GLOBAL_SUNLOCK on single processor system

Put back the header directives that only turns on AFS_GLOBAL_SUNLOCK
when compiling for multiprocessors system. When enabled on a single
processor OpenBSD system, it is possible to put the entire system
into a lengthy (minutes) lock state when performing multiple AFS
activities. The system behaves MUCH better when AFS_GLOBAL_SUNLOCK
is not set (no problems encopuntered). This whole locking mechanism
needs a bit more examination on OpenBSD before this is useful in
single processor mode.

Change-Id: I19813b78ad8d705b4f043ccb3a38c83e278972e9
Reviewed-on: http://gerrit.openafs.org/1276
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 6219c84243706ed46b922c2e037cceab2684d645)
Change-Id: I9891c469aae9de3ca1b7a334d3f54757c97ddc5f
Reviewed-on: http://gerrit.openafs.org/1257

15 years agoOpenBSD: allow for more graceful shutdown
Antoine Verheijen [Mon, 8 Feb 2010 22:33:38 +0000 (15:33 -0700)]
OpenBSD: allow for more graceful shutdown

A shutdown or unmount of AFS on OpenBSD will invariably result in a kernel
panic. This is because the afs_unmount() routine does not (can not?) force
vnode releases if the vnode is still busy. However, it continues on
nonetheless and dies a horrible death a little later.

This update causes a return from afs_unmount() with EBUSY if all the vnodes
weren't released. This results in error messages on shutdown but the overall
process continues more reliably and reboots, for example, work.

There is likely a better solution to this but at least this is no worse than
a system crash and it doesn't require console (or power button) intervention
so it should do until I have the chance to explore further.

Change-Id: Ia70f83bda748ea3d0b81b341a292e83121446567
Reviewed-on: http://gerrit.openafs.org/1275
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 5f39ae64bafe1e2073ff419fe62c2d5a86fc98f5)
Change-Id: I5b74a5b80c6e33ae49ac4f23fb6b3b5d7002b28a
Reviewed-on: http://gerrit.openafs.org/1260

15 years agoOpenBSD: fix lookup of network interfaces
Antoine Verheijen [Mon, 8 Feb 2010 22:23:03 +0000 (15:23 -0700)]
OpenBSD: fix lookup of network interfaces

Starting with OpenBSD 4.2, the interface list returned by sysctl using
NET_RT_IFLIST contains multiple versions of the data. This really
messes up the rx_getAllAddr_internal() routine that returns a list of
valid interfaces for the system (to the point where none are returned).

This change adds a routine that cleans up the data returned by sysctl
so it returns only a single (the most current) version of the data.
That stops afsd (among others) from being cranky when it starts up.

Change-Id: Ief1df0d2c3eb241c45b439a785ddb67d3afe992c
Reviewed-on: http://gerrit.openafs.org/1274
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit d06bc699f2e3848da8ce9a7fa20ac99db630bd1b)
Change-Id: I3c1f0b96b579784c6702ade34e33a3348fe82885
Reviewed-on: http://gerrit.openafs.org/1259

15 years agoOpenBSD: move AFS memory type offet
Antoine Verheijen [Mon, 8 Feb 2010 22:07:09 +0000 (15:07 -0700)]
OpenBSD: move AFS memory type offet

The internal malloc memory types for IPv6 (M_IP6OPT, ...) conflict
with the type numbers used to designate AFS memory (M_AFSFID, etc.).
This change moves the AFS memory type to a new number that does not
conflict. This is not a serious issue but can create real confusion
when trying to debug or track memory issues, among other things.

Change-Id: Icccaa7c06443cab008013414cb3c2ab4ea08889e
Reviewed-on: http://gerrit.openafs.org/1271
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 03ac7bd100d93f2f47b5e3724c61e3d93a9eca56)
Change-Id: I518850e0a4ac4e527f5cedba6cdc83daeafb6ddd
Reviewed-on: http://gerrit.openafs.org/1258

15 years agoFix segmentation fault in vsu_GetVolumeID
Antoine Verheijen [Mon, 8 Feb 2010 23:01:46 +0000 (16:01 -0700)]
Fix segmentation fault in vsu_GetVolumeID

When determining the volume type of a volume, vsu_GetVolumeID() checks
to see if the volume name ends in '.backup' or '.readonly' by backing
up the appropriate number of characters from the end of the name. It
does not, however, check to see if it skips past the beginning of the
volume name. This can result in a segmentation fault (which it has for
me on many occasions during a vos release) depending on where memory
is allocated or how/if memory is protected.

This patch corrects this behaviour by checking the volume name string
length prior to doing the string comparison.

Change-Id: Ia27fcac76b86ae2707663caa6bff365a4e8dd0da
Reviewed-on: http://gerrit.openafs.org/1269
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 4221d7acc8595a052dbc5fbb4366050c00d6ef37)
Reviewed-on: http://gerrit.openafs.org/1270

15 years agoAdd support for OpenBSD 4.6
Antoine Verheijen [Mon, 8 Feb 2010 22:45:25 +0000 (15:45 -0700)]
Add support for OpenBSD 4.6

Add config param header and sysname number for OpenBSD 4.6.

As well, add an additional parameter to a call to ifa_ifwithnet()
when looking up the MTU for an interface to indicate that the call
should use the default routing table. With the advent of OpenBSD
4.6, the system has started to make provisions for multiple routing
tables which included a change to the calling sequence for this
routine.

Change-Id: Ia616400094ed36bc6f0e37f86d3b7448d5bd32c2
(cherry picked from commit ab17ebef16a04180b2ede8c8ed07cd9c1871ae42)
Reviewed-on: http://gerrit.openafs.org/1261
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
15 years agoOpenBSD: allow code optimization to be turned off
Antoine Verheijen [Mon, 8 Feb 2010 21:44:55 +0000 (14:44 -0700)]
OpenBSD: allow code optimization to be turned off

Code optimization can not be turned of using the configuration script
(--disable-optimize, etc.) because the compiler directive is associated
with the wrong makefile variable. This fixes it.

Change-Id: I55759054fdad9677d9576e582df6829c4c508331
Reviewed-on: http://gerrit.openafs.org/1256
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
15 years agomacos package allow backrev
Derrick Brashear [Sun, 7 Feb 2010 00:48:44 +0000 (19:48 -0500)]
macos package allow backrev

in order to go back versions, tell the install not to enforce
"no backrev"

Change-Id: Ifb4bee86344560d63c9b8ab3cd789f25ed8629b8
Reviewed-on: http://gerrit.openafs.org/1249
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 80a1130612a68d14e1beda90013bd90d5523aa25)
Reviewed-on: http://gerrit.openafs.org/1250

15 years agofakestat should preclude afsdb lookups too
Derrick Brashear [Thu, 4 Feb 2010 00:01:28 +0000 (19:01 -0500)]
fakestat should preclude afsdb lookups too

macos tries to look up ._foo stuff. correctly identify those (mvstat 2, not
1) and also use tryEvalOnly to preclude AFSDB lookups

Change-Id: I490fe98d695c4d230210bc4e4645ea20cd4d8fa2
Reviewed-on: http://gerrit.openafs.org/1228
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 682db4d64d550af86dc5a09786e050c6a98ffb0c)
Reviewed-on: http://gerrit.openafs.org/1232

15 years agomacos prefs pane spelling
Derrick Brashear [Thu, 4 Feb 2010 02:46:06 +0000 (21:46 -0500)]
macos prefs pane spelling

fix spelling of link to the usual unix spelling

Change-Id: Id8464a22c049200526c6ffe471ea6dc6d4b0ed9a
Reviewed-on: http://gerrit.openafs.org/1230
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 0e8beecff3bffc0aa6f10d342cd4d100412ca29f)
Reviewed-on: http://gerrit.openafs.org/1231

15 years agono debian packaging in 1.4.x
Derrick Brashear [Tue, 2 Feb 2010 18:38:49 +0000 (13:38 -0500)]
no debian packaging in 1.4.x

don't try to build this here. slipped in from 1.5 pullup

Change-Id: Ie8702e4ba0af1c67542330d4d798dad2e2ec2b68
Reviewed-on: http://gerrit.openafs.org/1216
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
15 years agoAdd a set of strings for the InstallationCheck
Simon Wilkinson [Tue, 2 Feb 2010 15:59:12 +0000 (15:59 +0000)]
Add a set of strings for the InstallationCheck

InstallationCheck needs a strings dictionary to turn its errors
into human readable content. Add such a dictionary, and use the
correct product name and version for each Mac OS X release.

FIXES 126322

Change-Id: I8401a1163ea078e690152215c20db6970969ee04
Reviewed-on: http://gerrit.openafs.org/1208
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 7533adaf34ef76324b971a211bcbf3fba5b40627)
Reviewed-on: http://gerrit.openafs.org/1215

15 years agocreate debugging kext package for MacOS
Derrick Brashear [Sun, 17 Jan 2010 06:10:28 +0000 (01:10 -0500)]
create debugging kext package for MacOS

this creates and installs a debugging kext package for macos. it also
always installs the decode-panic script (which can be used even without
the debug kext)

Change-Id: Iff03de66cd3df2690f03333e6629d21660364cd1
Reviewed-on: http://gerrit.openafs.org/1120
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit cc47e765912e1a5dedddb6ef00ca8b8c8d567f0e)
Reviewed-on: http://gerrit.openafs.org/1214

15 years agoDon't echo from the InstallationCheck script
Simon Wilkinson [Tue, 2 Feb 2010 15:47:02 +0000 (15:47 +0000)]
Don't echo from the InstallationCheck script

Return codes from InstallationCheck are turned into errors by
the GUI - don't echo them out to stdout as well.

Change-Id: Iee9c1ff4687ea42ab8c18566493a8a92b6d51fed
Reviewed-on: http://gerrit.openafs.org/1206
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit c0724584680562330347026ee9ec72f74066bc51)
Reviewed-on: http://gerrit.openafs.org/1207

15 years agoafs_vnop_attrs: syntax error in conditional expression
Marc Dionne [Thu, 21 Jan 2010 22:53:42 +0000 (17:53 -0500)]
afs_vnop_attrs: syntax error in conditional expression

Add a missing && in a 2-line condition.
Not sure how this could have compiled successfully on the affected
platforms.

Change-Id: I2e8b791c6d8cd09795be1ef52c078ebfa5a3e53b
Reviewed-on: http://gerrit.openafs.org/1140
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit ddc64898e7b3a26e6514be63ef01672fe67cb851)
Reviewed-on: http://gerrit.openafs.org/1197

15 years agocall afs_osi_suser correctly in PNewUuid
Jeffrey Hutzelman [Mon, 1 Feb 2010 21:59:14 +0000 (16:59 -0500)]
call afs_osi_suser correctly in PNewUuid

we were using the wrong level of indirection on acred. fixed.

Change-Id: I00ab1a97b42717adc2d9d26e885b91c44103ab1d
Reviewed-on: http://gerrit.openafs.org/1190
Reviewed-by: Jeffrey Hutzelman <jhutz@cmu.edu>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit a97fffc08a02ad8583c7f7b50d41fe07c93520b8)
Reviewed-on: http://gerrit.openafs.org/1193

15 years agomake 1.4.12 rc2 openafs-stable-1_4_12pre2
Derrick Brashear [Mon, 1 Feb 2010 05:01:05 +0000 (00:01 -0500)]
make 1.4.12 rc2

push version strings for 1.4.12 pre2

Change-Id: I4ea9de19cc52c531d3ec9f4ec130449467f3e87d
Reviewed-on: http://gerrit.openafs.org/1186
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
15 years agorx idledeadtime don't track window wait
Derrick Brashear [Sat, 30 Jan 2010 18:54:20 +0000 (13:54 -0500)]
rx idledeadtime don't track window wait

if we're in writer mode and waiting for more window, don't consider it idle.

Change-Id: Id1e80f297929eef363ffe88bfe181b74bb331515
Reviewed-on: http://gerrit.openafs.org/1182
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit d52213fcc5dae5095d660e1861f77e90c07bb2ab)
Reviewed-on: http://gerrit.openafs.org/1183