From 05d5f012e0be9be1c2c82871a75ac76d437b9688 Mon Sep 17 00:00:00 2001 From: Jeffrey Altman Date: Sat, 15 Jan 2011 11:39:39 -0500 Subject: [PATCH] vol: initialize FdHandle_t stack objects In namei_create() a temporary FdHandle_t is allocated on the stack but was never initialized. Depending on what prior data was on the stack the FdHandle_t could result in subsequent operations failing in unpredictable ways. Change-Id: I6246930adc87cf84ad9c0913cda2d00e6f851bc1 Reviewed-on: http://gerrit.openafs.org/3667 Reviewed-by: Derrick Brashear Tested-by: BuildBot --- src/vol/namei_ops.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/vol/namei_ops.c b/src/vol/namei_ops.c index f85c2bfae..0d734ad26 100644 --- a/src/vol/namei_ops.c +++ b/src/vol/namei_ops.c @@ -754,6 +754,7 @@ namei_icreate(IHandle_t * lh, char *part, afs_uint32 p1, afs_uint32 p2, afs_uint b32_string_t str1; memset((void *)&tmp, 0, sizeof(IHandle_t)); + memset(&tfd, 0, sizeof(FdHandle_t)); tmp.ih_dev = nt_DriveToDev(part); if (tmp.ih_dev == -1) { @@ -879,6 +880,7 @@ namei_icreate(IHandle_t * lh, char *part, afs_uint32 p1, afs_uint32 p2, afs_uint int ogm_parm; memset((void *)&tmp, 0, sizeof(IHandle_t)); + memset(&tfd, 0, sizeof(FdHandle_t)); tmp.ih_dev = volutil_GetPartitionID(part); if (tmp.ih_dev == -1) { -- 2.39.5