From 0653c81c2abc658f32e07fc6cc1a1ff2b35a9041 Mon Sep 17 00:00:00 2001 From: Jeffrey Altman Date: Wed, 24 Apr 2013 23:34:45 -0400 Subject: [PATCH] Windows: SetFileRenameInfo Do not replace pSrcParentObject If pSrcParentObject is replaced by pTargetParentObject then the reference count obtained by the AFSFindObjectInfo() call at the start of AFSFileRenameInfo will be released on the wrong object. This will result in a reference leak on pSrcParentObject and an undercount on pTargetParentObject. pTargetParentObject can then be garbage collected while it is in use. Change-Id: Id10db257afbd4996a31eb98ad7eca69343297274 Reviewed-on: http://gerrit.openafs.org/9806 Reviewed-by: Peter Scott Reviewed-by: Rod Widdowson Tested-by: BuildBot Reviewed-by: Jeffrey Altman --- src/WINNT/afsrdr/kernel/lib/AFSFileInfo.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/WINNT/afsrdr/kernel/lib/AFSFileInfo.cpp b/src/WINNT/afsrdr/kernel/lib/AFSFileInfo.cpp index b7ffcaf64..6892b12b2 100644 --- a/src/WINNT/afsrdr/kernel/lib/AFSFileInfo.cpp +++ b/src/WINNT/afsrdr/kernel/lib/AFSFileInfo.cpp @@ -3244,8 +3244,6 @@ AFSSetRenameInfo( IN PIRP Irp) SetFlag( pSrcFcb->ObjectInformation->Flags, AFS_OBJECT_FLAGS_PARENT_FID); - pSrcParentObject = pTargetParentObject; - ulNotificationAction = FILE_ACTION_ADDED; } else -- 2.39.5