From 08002c553bda0a7bfa60a4d269b57f5b168e6668 Mon Sep 17 00:00:00 2001 From: Simon Wilkinson Date: Thu, 28 Feb 2013 22:07:12 +0000 Subject: [PATCH] libadmin: Don't free garbage Make sure that we initialise the nbulkentries structure to 0 before we start work, so that if the failure handler is called, it doesn't try to free garbage. Caught by coverity (#985980) Reviewed-on: http://gerrit.openafs.org/9317 Tested-by: BuildBot Reviewed-by: Jeffrey Altman (cherry picked from commit bf78bf2c115659b78c34d3bc9d1934bcff21c8cc) Change-Id: I24536b0bec47f381eee7cfcbe1feb89c373cca0f Reviewed-on: http://gerrit.openafs.org/11030 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Chas Williams - CONTRACTOR Reviewed-by: Stephan Wiesand --- src/libadmin/vos/afs_vosAdmin.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libadmin/vos/afs_vosAdmin.c b/src/libadmin/vos/afs_vosAdmin.c index d24dca466..55978e5fb 100644 --- a/src/libadmin/vos/afs_vosAdmin.c +++ b/src/libadmin/vos/afs_vosAdmin.c @@ -334,7 +334,8 @@ vos_BackupVolumeCreateMultiple(const void *cellHandle, int equal = 0; char backbuf[1024]; - memset((void *)&attr, 0, sizeof(attr)); + memset(&attr, 0, sizeof(attr)); + memset(&arrayEntries, 0, sizeof(arrayEntries)); /* * Validate arguments -- 2.39.5