From 0c9e55639cc02d90e9fd108572bb5ee64db3ddcc Mon Sep 17 00:00:00 2001 From: Simon Wilkinson Date: Thu, 25 Oct 2012 13:34:33 +0100 Subject: [PATCH] rx: Remove unreachable debug statement ReceivePacket has a dpf which is conditional on the packet having a zero callnumber. However, just before we reach this debug statement, we always return if the header doesn't have a call number included. So, the debug statement can never run. Just remove it, as it's potentially confusing. Change-Id: I5fad9f39c9a0c4aac50853aaf4f853b9f7715e61 Reviewed-on: http://gerrit.openafs.org/8295 Tested-by: BuildBot Reviewed-by: Jeffrey Altman Reviewed-by: Derrick Brashear --- src/rx/rx.c | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/src/rx/rx.c b/src/rx/rx.c index 2c8bf2685..631cd978f 100644 --- a/src/rx/rx.c +++ b/src/rx/rx.c @@ -3401,16 +3401,6 @@ rxi_ReceivePacket(struct rx_packet *np, osi_socket socket, call = rxi_NewCall(conn, channel); /* returns locked call */ *call->callNumber = currentCallNumber = np->header.callNumber; MUTEX_EXIT(&conn->conn_call_lock); -#ifdef RXDEBUG - if (np->header.callNumber == 0) - dpf(("RecPacket call 0 %d %s: %x.%u.%u.%u.%u.%u.%u flags %d, " - "packet %"AFS_PTR_FMT" len %d\n", - np->header.serial, rx_packetTypes[np->header.type - 1], - ntohl(conn->peer->host), ntohs(conn->peer->port), - np->header.serial, np->header.epoch, np->header.cid, - np->header.callNumber, np->header.seq, - np->header.flags, np, np->length)); -#endif call->state = RX_STATE_PRECALL; clock_GetTime(&call->queueTime); call->app.bytesSent = 0; @@ -3495,13 +3485,6 @@ rxi_ReceivePacket(struct rx_packet *np, osi_socket socket, * packet. This assignment should be safe. */ *call->callNumber = np->header.callNumber; -#ifdef RXDEBUG - if (np->header.callNumber == 0) - dpf(("RecPacket call 0 %d %s: %x.%u.%u.%u.%u.%u.%u flags %d, packet %"AFS_PTR_FMT" len %d\n", - np->header.serial, rx_packetTypes[np->header.type - 1], ntohl(conn->peer->host), ntohs(conn->peer->port), - np->header.serial, np->header.epoch, np->header.cid, np->header.callNumber, np->header.seq, - np->header.flags, np, np->length)); -#endif call->state = RX_STATE_PRECALL; clock_GetTime(&call->queueTime); call->app.bytesSent = 0; -- 2.39.5