From 0d28f8c0cec91d68023795e6ba9c769d60869f9e Mon Sep 17 00:00:00 2001 From: Simon Wilkinson Date: Fri, 15 Feb 2013 16:05:33 +0000 Subject: [PATCH] rxgen: Fix NULL pointer dereference Avoid a NULL pointer dereference if strchr doesn't find any occurence of '*' in the string. Whilst we handle the not found case when inserting a mid string terminator, we don't handle it when restoring the string to its previous value. Change-Id: Ie0b3e18d89073a1694bba2749111c73f59150bdb Reviewed-on: http://gerrit.openafs.org/9158 Reviewed-by: Derrick Brashear Tested-by: BuildBot Reviewed-by: Jeffrey Altman --- src/rxgen/rpc_parse.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/rxgen/rpc_parse.c b/src/rxgen/rpc_parse.c index f39d8b5f4..c8b94ca88 100644 --- a/src/rxgen/rpc_parse.c +++ b/src/rxgen/rpc_parse.c @@ -1413,7 +1413,8 @@ ss_ProcParams_setup(definition * defp) } f_print(fout, "\t%s %s", plist->pl.param_type, plist->pl.param_name); - *pntr = pres; + if (pntr) + *pntr = pres; } else if (strchr(plist->pl.param_type, '*') == 0) { f_print(fout, "\t%s %s", plist->pl.param_type, plist->pl.param_name); -- 2.39.5